[stubs] Unify (and optimize) implementation of ToObject.

src/ia32/interface-descriptors-ia32.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #if V8_TARGET_ARCH_IA32
 
 #include "src/interface-descriptors.h"
 
@@ skipping 85 matching lines @@
 
 
 void ToNumberDescriptor::InitializePlatformSpecific(
     CallInterfaceDescriptorData* data) {
   // ToNumberStub invokes a function, and therefore needs a context.
   Register registers[] = {eax};
   data->InitializePlatformSpecific(arraysize(registers), registers, NULL);
 }
 
 
+void ToObjectDescriptor::InitializePlatformSpecific(
+    CallInterfaceDescriptorData* data) {
+  // ToObjectStub invokes a function, and therefore needs a context.
+  Register registers[] = {eax};

[mvstanton, 2015/07/31 11:04:57]

You could also reduce the number of platform dependent lines by defining
ToObjectDescriptor::ReceiverRegister() { return eax; }

in this file, and then InitializePlatformSpecific() over in
interface-descriptors.cc.

[Benedikt Meurer, 2015/07/31 11:18:10]

Done. Thanks for the pointer.

+  data->InitializePlatformSpecific(arraysize(registers), registers, nullptr);
+}
+
+
 void NumberToStringDescriptor::InitializePlatformSpecific(
     CallInterfaceDescriptorData* data) {
   Register registers[] = {eax};
   data->InitializePlatformSpecific(arraysize(registers), registers, NULL);
 }
 
 
 void TypeofDescriptor::InitializePlatformSpecific(
     CallInterfaceDescriptorData* data) {
   Register registers[] = {ebx};
@@ skipping 250 matching lines @@
       edi,  // math rounding function
       edx,  // vector slot id
       ebx   // type vector
   };
   data->InitializePlatformSpecific(arraysize(registers), registers);
 }
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_IA32