Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266003002: Modifying TextBlobCacheTest to use SkRandomScalerContext (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : tweaks #

Patch Set 4 : disable random context for the time being #

Patch Set 5 : rebase #

Patch Set 6 : tweaks #

Patch Set 7 : tweaks #

Patch Set 8 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -76 lines) Patch
M src/core/SkScalerContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/fonts/SkRandomScalerContext.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/fonts/SkRandomScalerContext.cpp View 1 2 3 4 5 7 chunks +95 lines, -58 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrBatchAtlas.cpp View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M tests/TextBlobCacheTest.cpp View 1 2 3 4 5 6 7 6 chunks +34 lines, -14 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
joshualitt
I will write a GM after
5 years, 4 months ago (2015-07-30 16:06:30 UTC) #2
bungeman-skia
lgtm
5 years, 4 months ago (2015-07-30 16:19:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003002/1
5 years, 4 months ago (2015-07-30 16:22:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003002/40001
5 years, 4 months ago (2015-07-31 14:36:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/adcdca86ce425cf8c28bfad311cef028df756ee8
5 years, 4 months ago (2015-07-31 14:44:15 UTC) #10
joshualitt
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1267623004/ by joshualitt@google.com. ...
5 years, 4 months ago (2015-07-31 14:54:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003002/60001
5 years, 4 months ago (2015-07-31 15:37:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2394) Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-07-31 15:37:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003002/120001
5 years, 4 months ago (2015-07-31 18:30:14 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2428)
5 years, 4 months ago (2015-07-31 18:33:35 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1266003002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1266003002/140001
5 years, 4 months ago (2015-07-31 18:38:13 UTC) #24
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 18:45:25 UTC) #25
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/65e96b4eb94c1b692f7decc18915cff77c5f1ab3

Powered by Google App Engine
This is Rietveld 408576698