Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1265943002: Use proper verify method when checking slots buffer entries. (Closed)

Created:
5 years, 4 months ago by Hannes Payer (out of office)
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use proper verify method when checking slots buffer entries. BUG=chromium:454297 LOG=n Committed: https://crrev.com/66f540c0738ce770359232f0bafdd9cb099d6569 Cr-Commit-Position: refs/heads/master@{#29930}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/heap/mark-compact.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Hannes Payer (out of office)
5 years, 4 months ago (2015-07-30 11:42:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265943002/60001
5 years, 4 months ago (2015-07-30 11:58:17 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-07-30 11:58:18 UTC) #6
Michael Lippautz
lgtm lgtm
5 years, 4 months ago (2015-07-30 11:58:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265943002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265943002/60001
5 years, 4 months ago (2015-07-30 12:02:16 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-30 12:22:25 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 12:22:40 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/66f540c0738ce770359232f0bafdd9cb099d6569
Cr-Commit-Position: refs/heads/master@{#29930}

Powered by Google App Engine
This is Rietveld 408576698