Make LayoutFlowThread::fragmentsBoundingBox() faster.

Source/core/layout/MultiColumnFragmentainerGroup.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/layout/MultiColumnFragmentainerGroup.h"
 
 #include "core/layout/LayoutMultiColumnSet.h"
 
@@ skipping 157 matching lines @@
         return LayoutPoint(localPoint.x() + logicalTopInFlowThreadAt(columnIndex), localPoint.y());
     }
     LayoutUnit columnStart = m_columnSet.style()->isLeftToRightDirection() ? LayoutUnit() : columnRect.width();
     if (localPoint.y() < 0)
         localPoint = LayoutPoint(columnStart, LayoutUnit());
     else if (localPoint.y() > logicalHeight())
         localPoint = LayoutPoint(columnStart, logicalHeight());
     return LayoutPoint(localPoint.x(), localPoint.y() + logicalTopInFlowThreadAt(columnIndex));
 }
 
+LayoutRect MultiColumnFragmentainerGroup::fragmentsBoundingBox(const LayoutRect& boundingBoxInFlowThread) const

[leviw_travelin_and_unemployed, 2015/08/03 21:32:59]

It's difficult for me to be 100% certain of this code, but it seems right.

+{
+    // Find the start and end column intersected by the bounding box.
+    LayoutRect flippedBoundingBoxInFlowThread(boundingBoxInFlowThread);
+    LayoutFlowThread* flowThread = m_columnSet.flowThread();
+    flowThread->flipForWritingMode(flippedBoundingBoxInFlowThread);
+    bool isHorizontalWritingMode = m_columnSet.isHorizontalWritingMode();
+    LayoutUnit boundingBoxLogicalTop = isHorizontalWritingMode ? flippedBoundingBoxInFlowThread.y() : flippedBoundingBoxInFlowThread.x();
+    LayoutUnit boundingBoxLogicalBottom = (isHorizontalWritingMode ? flippedBoundingBoxInFlowThread.maxY() : flippedBoundingBoxInFlowThread.maxX());

[leviw_travelin_and_unemployed, 2015/08/03 21:33:00]

Nit: inconsistent parenthesis usage. Perhaps you should just put both of these
in an if/else.

[mstensho (USE GERRIT), 2015/08/04 10:48:11]

No idea where those extraneous parentheses came from (I normally try to use as
few as the compiler settings allow). I just removed them.

Done.

+    if (boundingBoxLogicalBottom <= logicalTopInFlowThread() || boundingBoxLogicalTop >= logicalBottomInFlowThread())
+        return LayoutRect(); // The bounding box doesn't intersect this fragmentainer group.
+    unsigned startColumn;
+    unsigned endColumn;
+    columnIntervalForBlockRangeInFlowThread(boundingBoxLogicalTop, boundingBoxLogicalBottom, startColumn, endColumn);
+
+    LayoutRect startColumnFlowThreadOverflowPortion = flowThreadPortionOverflowRectAt(startColumn);
+    flowThread->flipForWritingMode(startColumnFlowThreadOverflowPortion);
+    LayoutRect startColumnRect(boundingBoxInFlowThread);
+    startColumnRect.intersect(startColumnFlowThreadOverflowPortion);
+    startColumnRect.move(flowThreadTranslationAtOffset(logicalTopInFlowThreadAt(startColumn)));
+    if (startColumn == endColumn)
+        return startColumnRect; // It all takes place in one column. We're done.
+
+    LayoutRect endColumnFlowThreadOverflowPortion = flowThreadPortionOverflowRectAt(endColumn);
+    flowThread->flipForWritingMode(endColumnFlowThreadOverflowPortion);
+    LayoutRect endColumnRect(boundingBoxInFlowThread);
+    endColumnRect.intersect(endColumnFlowThreadOverflowPortion);
+    endColumnRect.move(flowThreadTranslationAtOffset(logicalTopInFlowThreadAt(endColumn)));
+    return unionRect(startColumnRect, endColumnRect);
+}
+
 void MultiColumnFragmentainerGroup::collectLayerFragments(DeprecatedPaintLayerFragments& fragments, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect) const
 {
     // |layerBoundingBox| is in the flow thread coordinate space, relative to the top/left edge of
     // the flow thread, but note that it has been converted with respect to writing mode (so that
     // it's visual/physical in that sense).
     //
     // |dirtyRect| is visual, relative to the multicol container.
     //
     // Then there's the output from this method - the stuff we put into the list of fragments. The
     // fragment.paginationOffset point is the actual visual translation required to get from a
@@ skipping 380 matching lines @@
     append(MultiColumnFragmentainerGroup(m_columnSet));
     return last();
 }
 
 void MultiColumnFragmentainerGroupList::deleteExtraGroups()
 {
     shrink(1);
 }
 
 } // namespace blink