Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: build/android/pylib/chrome_test_server_spawner.py

Issue 12659003: Cleanup test server instance after running each a test in gtest test runner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Just cleanup test server instance Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/chrome_test_server_spawner.py
diff --git a/build/android/pylib/chrome_test_server_spawner.py b/build/android/pylib/chrome_test_server_spawner.py
index f70bf669380d96903bd4e90137b76c926924b501..e02cf655208e85a62c0e35747c1134d180dc0357 100644
--- a/build/android/pylib/chrome_test_server_spawner.py
+++ b/build/android/pylib/chrome_test_server_spawner.py
@@ -403,6 +403,10 @@ class SpawningServer(object):
time.sleep(1)
def Stop(self):
+ self.CleanupTestServer()
+ self.server.shutdown()
+
+ def CleanupTestServer(self):
frankf 2013/03/08 19:59:52 Could you also add dosctrings for all the methods
nilesh 2013/03/08 23:37:52 Renamed and added doc.
if self.server.test_server_instance:
self.server.test_server_instance.Stop()
- self.server.shutdown()
+ self.server.test_server_instance = None

Powered by Google App Engine
This is Rietveld 408576698