Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1265853002: Fix closure compile through a series of stupid hacks (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compile through a series of stupid hacks R=michaelpg@chromium.org BUGGY=compiler+pass Committed: https://crrev.com/24a1fe224b85b1ecfe01e23a036279189a4dc962 Cr-Commit-Position: refs/heads/master@{#341059}

Patch Set 1 #

Patch Set 2 : match enums #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M chrome/browser/resources/options/chromeos/power_overlay.js View 1 4 chunks +24 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/power_handler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/power_overlay_browsertest.js View 1 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dan Beam
5 years, 4 months ago (2015-07-30 01:30:16 UTC) #1
michaelpg
lgtm i reserve the right to convert type to a boolean later
5 years, 4 months ago (2015-07-30 01:37:44 UTC) #2
Dan Beam
"we reserve the right to change any code at any time for any reason" - ...
5 years, 4 months ago (2015-07-30 01:41:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265853002/20001
5 years, 4 months ago (2015-07-30 02:12:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 02:43:19 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 02:43:47 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24a1fe224b85b1ecfe01e23a036279189a4dc962
Cr-Commit-Position: refs/heads/master@{#341059}

Powered by Google App Engine
This is Rietveld 408576698