components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 1265843005: Refactor feedback to use native JS object

Unified Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 1265843005: Refactor feedback to use native JS object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-mojo-combine

Patch Set: Param order Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/dom_distiller/content/browser/distiller_javascript_service_impl.cc ('K') | « components/dom_distiller/content/browser/dom_distiller_viewer_source.cc ('k') | components/dom_distiller/content/renderer/distiller_native_javascript.h » ('j') | components/dom_distiller/content/renderer/distiller_native_javascript.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/common/distiller_javascript_service.mojom

diff --git a/components/dom_distiller/content/common/distiller_javascript_service.mojom b/components/dom_distiller/content/common/distiller_javascript_service.mojom

index cf7b7a04b9476dca9a40e5054bef086b535b426f..d63f4fed372e32a55306ce44a5a0f61d1daef940 100644

--- a/components/dom_distiller/content/common/distiller_javascript_service.mojom

+++ b/components/dom_distiller/content/common/distiller_javascript_service.mojom

@@ -8,4 +8,5 @@ module dom_distiller;

// renderer when a distiller JavaScript function is called.

interface DistillerJavaScriptService {

HandleDistillerEchoCall(string message);

+ HandleDistillerFeedbackCall(bool good);

nyquist 2015/09/10 19:04:13 Should we have comments for these two methods? Or

mdjones 2015/09/11 16:50:13 I tried to make the function names self-documentin

nyquist 2015/09/11 17:14:22 Oh. Right. Yeah, I think the method names are expl

mdjones 2015/09/11 18:25:54 I would expect that kind of comment to be written

};