components/dom_distiller/content/renderer/distiller_native_javascript.h - Issue 1265843005: Refactor feedback to use native JS object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distiller_native_javascript.h

Issue 1265843005: Refactor feedback to use native JS object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-mojo-combine

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/dom_distiller/content/browser/distiller_javascript_service_impl.h ('K') | « components/dom_distiller/content/common/distiller_javascript_service.mojom ('k') | components/dom_distiller/content/renderer/distiller_native_javascript.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distiller_native_javascript.h

diff --git a/components/dom_distiller/content/renderer/distiller_native_javascript.h b/components/dom_distiller/content/renderer/distiller_native_javascript.h

index 180ef9fcb08e26ed93db4792e169d890ea0a758c..694198c3f2c39da4816c618eb515ce2df01f34ac 100644

--- a/components/dom_distiller/content/renderer/distiller_native_javascript.h

+++ b/components/dom_distiller/content/renderer/distiller_native_javascript.h

@@ -25,10 +25,16 @@ class DistillerNativeJavaScript {

void AddJavaScriptObjectToFrame(v8::Local<v8::Context> context);

private:

+ // Make sure the mojo service is connected.

+ void ensureServiceConnected();

// Native code for "distiller.echo" in JavaScript. This simply returns the

// provided string.

std::string DistillerEcho(const std::string& message);

+ // Send feedback about distillation quality.

+ void DistillerSendFeedback(bool good);

content::RenderFrame* render_frame_;

DistillerJavaScriptServicePtr distiller_js_service_;

};