Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: components/dom_distiller/core/javascript/dom_distiller_viewer.js

Issue 1265843005: Refactor feedback to use native JS object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@js-mojo-combine
Patch Set: impl comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/dom_distiller/content/renderer/distiller_native_javascript.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This variable will be changed by iOS scripts. 5 // This variable will be changed by iOS scripts.
6 var distiller_on_ios = false; 6 var distiller_on_ios = false;
7 7
8 function addToPage(html) { 8 function addToPage(html) {
9 var div = document.createElement('div'); 9 var div = document.createElement('div');
10 div.innerHTML = html; 10 div.innerHTML = html;
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 // variable is set in distiller_viewer.cc before this function is run. 145 // variable is set in distiller_viewer.cc before this function is run.
146 if (distiller_on_ios) return; 146 if (distiller_on_ios) return;
147 147
148 document.getElementById('feedbackYes').innerText = yesText; 148 document.getElementById('feedbackYes').innerText = yesText;
149 document.getElementById('feedbackNo').innerText = noText; 149 document.getElementById('feedbackNo').innerText = noText;
150 document.getElementById('feedbackQuestion').innerText = questionText; 150 document.getElementById('feedbackQuestion').innerText = questionText;
151 151
152 document.getElementById('feedbackContainer').classList.remove("hidden"); 152 document.getElementById('feedbackContainer').classList.remove("hidden");
153 } 153 }
154 154
155 /**
156 * Send feedback about this distilled article.
157 * @param good True if the feedback was positive, false if negative.
158 */
159 function sendFeedback(good) {
160 var img = document.createElement('img');
161 if (good) {
162 img.src = '/feedbackgood';
163 } else {
164 img.src = '/feedbackbad';
165 }
166 img.style.display = "none";
167 document.body.appendChild(img);
168 }
169
170 // Add a listener to the "View Original" link to report opt-outs. 155 // Add a listener to the "View Original" link to report opt-outs.
171 document.getElementById('closeReaderView').addEventListener('click', 156 document.getElementById('closeReaderView').addEventListener('click',
172 function(e) { 157 function(e) {
173 var img = document.createElement('img'); 158 var img = document.createElement('img');
174 img.src = "/vieworiginal"; 159 img.src = "/vieworiginal";
175 img.style.display = "none"; 160 img.style.display = "none";
176 document.body.appendChild(img); 161 document.body.appendChild(img);
177 }, true); 162 }, true);
178 163
179 document.getElementById('feedbackYes').addEventListener('click', function(e) { 164 document.getElementById('feedbackYes').addEventListener('click', function(e) {
180 sendFeedback(true); 165 if (distiller) {
166 distiller.sendFeedback(true);
167 }
181 document.getElementById('feedbackContainer').className += " fadeOut"; 168 document.getElementById('feedbackContainer').className += " fadeOut";
182 }, true); 169 }, true);
183 170
184 document.getElementById('feedbackNo').addEventListener('click', function(e) { 171 document.getElementById('feedbackNo').addEventListener('click', function(e) {
185 sendFeedback(false); 172 if (distiller) {
173 distiller.sendFeedback(false);
174 }
186 document.getElementById('feedbackContainer').className += " fadeOut"; 175 document.getElementById('feedbackContainer').className += " fadeOut";
187 }, true); 176 }, true);
188 177
189 document.getElementById('feedbackContainer').addEventListener('animationend', 178 document.getElementById('feedbackContainer').addEventListener('animationend',
190 function(e) { 179 function(e) {
191 var feedbackContainer = document.getElementById('feedbackContainer'); 180 var feedbackContainer = document.getElementById('feedbackContainer');
192 feedbackContainer.classList.remove("fadeOut"); 181 feedbackContainer.classList.remove("fadeOut");
193 feedbackContainer.className += " hidden"; 182 feedbackContainer.className += " hidden";
194 document.getElementById('contentWrap').style.paddingBottom = '120px'; 183 document.getElementById('contentWrap').style.paddingBottom = '120px';
195 setTimeout(function() { 184 setTimeout(function() {
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
401 shiftY: shiftY 390 shiftY: shiftY
402 }; 391 };
403 } 392 }
404 }; 393 };
405 }()); 394 }());
406 395
407 window.addEventListener('touchstart', pincher.handleTouchStart, false); 396 window.addEventListener('touchstart', pincher.handleTouchStart, false);
408 window.addEventListener('touchmove', pincher.handleTouchMove, false); 397 window.addEventListener('touchmove', pincher.handleTouchMove, false);
409 window.addEventListener('touchend', pincher.handleTouchEnd, false); 398 window.addEventListener('touchend', pincher.handleTouchEnd, false);
410 window.addEventListener('touchcancel', pincher.handleTouchCancel, false); 399 window.addEventListener('touchcancel', pincher.handleTouchCancel, false);
OLDNEW
« no previous file with comments | « components/dom_distiller/content/renderer/distiller_native_javascript.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698