Refactor feedback to use native JS object

components/dom_distiller/content/renderer/distiller_native_javascript.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/dom_distiller/content/renderer/distiller_native_javascript.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 27 matching lines @@
 
   v8::Local<v8::Object> distiller_obj =
       GetOrCreateDistillerObject(isolate, context->Global());
 
   distiller_obj->Set(
       gin::StringToSymbol(isolate, "echo"),
       gin::CreateFunctionTemplate(
           isolate, base::Bind(&DistillerNativeJavaScript::DistillerEcho,
                               base::Unretained(this)))
           ->GetFunction());
+
+  distiller_obj->Set(
+      gin::StringToSymbol(isolate, "sendFeedback"),
+      gin::CreateFunctionTemplate(
+          isolate, base::Bind(&DistillerNativeJavaScript::DistillerSendFeedback,
+                              base::Unretained(this)))
+          ->GetFunction());
 }
 
-std::string DistillerNativeJavaScript::DistillerEcho(
-    const std::string& message) {
+void DistillerNativeJavaScript::ensureServiceConnected() {
   if (!distiller_js_service_) {
     render_frame_->GetServiceRegistry()->ConnectToRemoteService(

[nyquist, 2015/09/10 19:04:13]

Is this a blocking call?

[mdjones, 2015/09/11 16:50:13]

No, from my understanding you immediately get back a handle to a pipe which is
either connected or isn't (allowing messages to be put into it either way). The
only blocking call I am aware of is the one to get a return value from a call to
a remote service.

[nyquist, 2015/09/11 17:14:23]

So if it's not blocking, what will happen when you later call
distiller_js_service_->HandleFoobarCall(...)?

[mdjones, 2015/09/11 18:25:54]

It fails quietly. It is possible to check for an error but in this case is
unhelpful.

         mojo::GetProxy(&distiller_js_service_));
   }
+}
+
+void DistillerNativeJavaScript::DistillerSendFeedback(bool good) {
+  ensureServiceConnected();
+  distiller_js_service_->HandleDistillerFeedbackCall(good);
+}
+
+std::string DistillerNativeJavaScript::DistillerEcho(
+    const std::string& message) {
+  ensureServiceConnected();
   // TODO(mdjones): It is possible and beneficial to have information
   // returned from the browser process with these calls. The problem
   // is waiting blocks this process.
   distiller_js_service_->HandleDistillerEchoCall(message);
 
   return message;
 }
 
 v8::Local<v8::Object> GetOrCreateDistillerObject(v8::Isolate* isolate,
                                                  v8::Local<v8::Object> global) {
   v8::Local<v8::Object> distiller_obj;
   v8::Local<v8::Value> distiller_value =
       global->Get(gin::StringToV8(isolate, "distiller"));
   if (distiller_value.IsEmpty() || !distiller_value->IsObject()) {
     distiller_obj = v8::Object::New(isolate);
     global->Set(gin::StringToSymbol(isolate, "distiller"), distiller_obj);
   } else {
     distiller_obj = v8::Local<v8::Object>::Cast(distiller_value);
   }
   return distiller_obj;
 }
 
 }  // namespace dom_distiller