extensions/browser/api/usb/usb_api.cc - Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/usb/usb_api.cc

Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated code to continue instead of return if error happens when getting config descriptor Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/usb/usb_api.cc

diff --git a/extensions/browser/api/usb/usb_api.cc b/extensions/browser/api/usb/usb_api.cc

index 7c6648750d398aa08ed678ce336a25eb9add34b7..be128bf0eb2ddcb5e7c47e030b5697c656793837 100644

--- a/extensions/browser/api/usb/usb_api.cc

+++ b/extensions/browser/api/usb/usb_api.cc

@@ -766,7 +766,7 @@ ExtensionFunction::ResponseAction UsbGetConfigurationFunction::Run() {

}

const UsbConfigDescriptor* config_descriptor =

- device_handle->GetDevice()->GetConfiguration();

+ device_handle->GetDevice()->GetActiveConfiguration();

if (config_descriptor) {

ConfigDescriptor config;

ConvertConfigDescriptor(*config_descriptor, &config);

@@ -794,7 +794,7 @@ ExtensionFunction::ResponseAction UsbListInterfacesFunction::Run() {

}