device/usb/usb_device_handle_impl.cc - Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_device_handle_impl.cc

Issue 1265833005: Get all the UsbConfigDescriptor for the device configuration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated code to continue instead of return if error happens when getting config descriptor Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_device_handle_impl.cc

diff --git a/device/usb/usb_device_handle_impl.cc b/device/usb/usb_device_handle_impl.cc

index 6a0861263e58f50557f68731b46079fecd62df9b..eb657a53d22d53250cfecf13660e7fbe264a3a57 100644

--- a/device/usb/usb_device_handle_impl.cc

+++ b/device/usb/usb_device_handle_impl.cc

@@ -16,7 +16,6 @@

#include "base/thread_task_runner_handle.h"

#include "components/device_event_log/device_event_log.h"

#include "device/usb/usb_context.h"

-#include "device/usb/usb_descriptors.h"

#include "device/usb/usb_device_impl.h"

#include "device/usb/usb_error.h"

#include "device/usb/usb_service.h"

@@ -776,7 +775,7 @@ void UsbDeviceHandleImpl::ResetDeviceOnBlockingThread(

void UsbDeviceHandleImpl::RefreshEndpointMap() {

DCHECK(thread_checker_.CalledOnValidThread());

endpoint_map_.clear();

- const UsbConfigDescriptor* config = device_->GetConfiguration();

+ const UsbConfigDescriptor* config = device_->GetActiveConfiguration();

if (config) {

for (const auto& map_entry : claimed_interfaces_) {

int interface_number = map_entry.first;

« device/usb/usb_device.h ('K') | « device/usb/usb_device_filter_unittest.cc ('k') | device/usb/usb_device_impl.h » ('j') | device/usb/usb_device_impl.h » ('J')