Issue 1265823002: Auto-sandboxing: Don't expand instructions when in a bundle-locked group

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265823002: Auto-sandboxing: Don't expand instructions when in a bundle-locked group (Closed)

Created:
5 years, 4 months ago by Derek Schuff

Modified:
5 years, 4 months ago

Reviewers:
dominickd

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Auto-sandboxing: Don't expand instructions when in a bundle-locked group This ensures that any manually-written assembly which is correct for NaCl won't be touched (we'll assume users who do this know what they're doing). It also keeps the auto-sandboxer from touching any expansions done by other parts of the compiler (e.g. the RewritePass). R=dominickd@google.com Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/00317bda1dcd7698a1ea3a7b14a74bfb95c480d9

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	lib/MC/MCAsmStreamer.cpp	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	lib/MC/MCObjectStreamer.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
A	test/MC/X86/nacl-test-recursive-expand.s	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Derek Schuff

5 years, 4 months ago (2015-07-30 00:36:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00317bda1dcd7698a1ea3a7b14a74bfb95c480d9 (presubmit successful).