Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1265763002: Args structs to GrPathRenderer functions (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Also provides the ResourceProvider to onDrawPath which allows the DF PR to no longer require access to GrContext. Committed: https://skia.googlesource.com/skia/+/0aff2fa82a5fa9f99aa77327dac3e9e803b4ed07

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Patch Set 4 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+407 lines, -495 lines) Patch
M src/gpu/GrAAConvexPathRenderer.h View 1 2 3 1 chunk +3 lines, -14 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 2 2 chunks +10 lines, -20 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.h View 1 2 3 2 chunks +10 lines, -23 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 2 6 chunks +23 lines, -38 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.h View 1 2 3 1 chunk +4 lines, -16 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 2 2 chunks +11 lines, -22 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.h View 1 2 3 1 chunk +3 lines, -14 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 2 2 chunks +20 lines, -29 lines 0 comments Download
M src/gpu/GrAddPathRenderers_default.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 3 chunks +39 lines, -9 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.h View 1 2 chunks +5 lines, -16 lines 0 comments Download
M src/gpu/GrDashLinePathRenderer.cpp View 1 2 1 chunk +7 lines, -18 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.h View 1 2 3 2 chunks +4 lines, -19 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 1 chunk +16 lines, -30 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/gpu/GrPathRenderer.h View 4 chunks +140 lines, -77 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 1 chunk +8 lines, -1 line 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 2 3 1 chunk +4 lines, -15 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 2 chunks +15 lines, -26 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.h View 1 1 chunk +6 lines, -21 lines 0 comments Download
M src/gpu/GrStencilAndCoverPathRenderer.cpp View 1 5 chunks +25 lines, -33 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.h View 1 chunk +3 lines, -14 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 2 chunks +10 lines, -20 lines 0 comments Download
M src/gpu/GrTest.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 2 chunks +29 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bsalomon
5 years, 4 months ago (2015-07-30 18:00:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265763002/60001
5 years, 4 months ago (2015-07-30 22:24:51 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-07-30 22:24:52 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 4 months ago (2015-07-31 04:24:07 UTC) #7
joshualitt
On 2015/07/31 04:24:07, commit-bot: I haz the power wrote: > No LGTM from a valid ...
5 years, 4 months ago (2015-07-31 12:53:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265763002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265763002/60001
5 years, 4 months ago (2015-07-31 13:47:48 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 13:48:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0aff2fa82a5fa9f99aa77327dac3e9e803b4ed07

Powered by Google App Engine
This is Rietveld 408576698