[Extensions Mac UI] Fix more bugs in the action overflow container

[Extensions Mac UI] Fix more bugs in the action overflow container

There were more layout bugs in the extension overflow container, stemming
from improperly assigning frames to the buttons and from Cocoa's unwillingness
to let us do fun things in the wrench menu (it tries to automatically resize
before showing, forcing the overflow off the edge). Correct the logic for the
former, and tweak the overflow bounds for the latter. Also add a interactive
ui test to try and prevent us from regressing.

BUG=

Committed: https://crrev.com/48601123e83ec912c29f564e2692ef93c66fd933
Cr-Commit-Position: refs/heads/master@{#341426}

[Devlin, 2015-07-29 23:31:35]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2015-07-29 23:31:36]

Another one for you, Avi

[Avi (use Gerrit), 2015-07-30 02:50:35]

lgtm

nits only

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
File
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
(right):

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:41:
// An arbitrary high id so that it's not taken.
I'm sure one day you will trace down some weird bug to this function and laugh
and cry.

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:47:
" to have increased width";
Did you intend that double space? Drop the space before "to" since you already
have one at the end of the previous line.

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:166:
extensions::ExtensionToolbarModel* model_ = nil;
nullptr for C++ objects, nil for ObjC ones.

[Devlin, 2015-07-31 18:29:44]

Patchset #2 (id:20001) has been deleted

[Devlin, 2015-07-31 18:29:50]

Patchset #2 (id:40001) has been deleted

[Devlin, 2015-07-31 19:48:30]

So, apparently even though the original patch passes on OS X 10.10 (my local
machine), whatever the trybots are running failed.  I don't know why I'm
surprised anymore that Cocoa behaves totally differently on different versions.
:/  Anyway, minor adjustment with semi-hacky solution added that seems to make
all versions happy.  Mind taking another quick look?

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
File
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
(right):

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:41:
// An arbitrary high id so that it's not taken.
On 2015/07/30 02:50:35, Avi wrote:
> I'm sure one day you will trace down some weird bug to this function and laugh
> and cry.

This should only be used when the menu item is used, so I think we're okay.  But
there is always that possibility. :)

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:47:
" to have increased width";
On 2015/07/30 02:50:35, Avi wrote:
> Did you intend that double space? Drop the space before "to" since you already
> have one at the end of the previous line.

Done.

https://codereview.chromium.org/1265743003/diff/1/chrome/browser/ui/cocoa/ext...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:166:
extensions::ExtensionToolbarModel* model_ = nil;
On 2015/07/30 02:50:35, Avi wrote:
> nullptr for C++ objects, nil for ObjC ones.

Heh, did that at first, and thought it looked so weird, and wasn't sure of the
rule.  Now I know. :)  Done.

[Avi (use Gerrit), 2015-07-31 20:26:19]

lgtm

I don't mind the hackery.

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
(right):

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:47:
"to have increased wewidthe";
"width"?

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:316:
EXPECT_EQ(NSMinX([[[overflowContainer superview] superview] frame]), 0) <<
For EXPECT_EQ, expected value is the first parameter (this line and the one
above) for best output.

[Devlin, 2015-07-31 22:12:36]

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
File
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm
(right):

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:47:
"to have increased wewidthe";
On 2015/07/31 20:26:19, Avi wrote:
> "width"?

Whoops!  (Was experimenting with different length errors ;))  Thanks for
catching it.

https://codereview.chromium.org/1265743003/diff/60001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm:316:
EXPECT_EQ(NSMinX([[[overflowContainer superview] superview] frame]), 0) <<
On 2015/07/31 20:26:19, Avi wrote:
> For EXPECT_EQ, expected value is the first parameter (this line and the one
> above) for best output.

Done.

[Devlin, 2015-07-31 22:12:38]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-07-31 22:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1265743003/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-07-31 22:12:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265743003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265743003/80001

[commit-bot: I haz the power, 2015-07-31 22:18:14]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-07-31 22:18:59]

Patchset 3 (id:??) landed as
https://crrev.com/48601123e83ec912c29f564e2692ef93c66fd933
Cr-Commit-Position: refs/heads/master@{#341426}