Implement the texture uploading of ASTC compression for WebGL(part II)

Source/modules/webgl/WebGLCompressedTextureASTC.cpp

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+
+#include "modules/webgl/WebGLCompressedTextureASTC.h"
+
+#include "modules/webgl/WebGLRenderingContextBase.h"
+
+namespace blink {
+
+const WebGLCompressedTextureASTC::BlockSizeCompressASTC
+    WebGLCompressedTextureASTC::kBlockSizeCompressASTC[] =
+    {
+        GL_COMPRESSED_RGBA_ASTC_4x4_KHR,           4, 4,
+        GL_COMPRESSED_RGBA_ASTC_5x4_KHR,           5, 4,
+        GL_COMPRESSED_RGBA_ASTC_5x5_KHR,           5, 5,
+        GL_COMPRESSED_RGBA_ASTC_6x5_KHR,           6, 5,
+        GL_COMPRESSED_RGBA_ASTC_6x6_KHR,           6, 6,
+        GL_COMPRESSED_RGBA_ASTC_8x5_KHR,           8, 5,
+        GL_COMPRESSED_RGBA_ASTC_8x6_KHR,           8, 6,
+        GL_COMPRESSED_RGBA_ASTC_8x8_KHR,           8, 8,
+        GL_COMPRESSED_RGBA_ASTC_10x5_KHR,          10, 5,
+        GL_COMPRESSED_RGBA_ASTC_10x6_KHR,          10, 6,
+        GL_COMPRESSED_RGBA_ASTC_10x8_KHR,          10, 8,
+        GL_COMPRESSED_RGBA_ASTC_10x10_KHR,         10, 10,
+        GL_COMPRESSED_RGBA_ASTC_12x10_KHR,         12, 10,
+        GL_COMPRESSED_RGBA_ASTC_12x12_KHR,         12, 12,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_4x4_KHR,   4, 4,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_5x4_KHR,   5, 4,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_5x5_KHR,   5, 5,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_6x5_KHR,   6, 5,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_6x6_KHR,   6, 6,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_8x5_KHR,   8, 5,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_8x6_KHR,   8, 6,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_8x8_KHR,   8, 8,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_10x5_KHR,  10, 5,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_10x6_KHR,  10, 6,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_10x8_KHR,  10, 8,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_10x10_KHR, 10, 10,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_12x10_KHR, 12, 10,
+        GL_COMPRESSED_SRGB8_ALPHA8_ASTC_12x12_KHR, 12, 12
+    };
+
+const int WebGLCompressedTextureASTC::kSizeOfBlockSizeCompressASTC =
+    sizeof(WebGLCompressedTextureASTC::kBlockSizeCompressASTC) /
+    sizeof(WebGLCompressedTextureASTC::kBlockSizeCompressASTC[0]);
+
+WebGLCompressedTextureASTC::WebGLCompressedTextureASTC(WebGLRenderingContextBase* context)
+    : WebGLExtension(context)
+{
+    for (int i = 0; i < WebGLCompressedTextureASTC::kSizeOfBlockSizeCompressASTC; i++) {
+        context->addCompressedTextureFormat(
+            WebGLCompressedTextureASTC::kBlockSizeCompressASTC[i].CompressType);
+    }
+}
+
+WebGLCompressedTextureASTC::~WebGLCompressedTextureASTC()
+{
+}
+
+WebGLExtensionName WebGLCompressedTextureASTC::name() const
+{
+    return WebGLCompressedTextureASTCName;
+}
+
+PassRefPtrWillBeRawPtr<WebGLCompressedTextureASTC> WebGLCompressedTextureASTC::create(WebGLRenderingContextBase* context)
+{
+    return adoptRefWillBeNoop(new WebGLCompressedTextureASTC(context));
+}
+
+bool WebGLCompressedTextureASTC::supported(WebGLRenderingContextBase* context)
+{
+    Extensions3DUtil* extensionsUtil = context->extensionsUtil();
+    return extensionsUtil->supportsExtension("GL_KHR_texture_compression_astc_ldr");
+}
+
+const char* WebGLCompressedTextureASTC::extensionName()
+{
+    return "WEBGL_compressed_texture_astc";

[bajones, 2015/08/07 22:01:09]

The intermixing of "compressed_texture_astc" and "compressed_texture_astc_ldr"
in these patches feels strange. Shouldn't this be
"WEBGL_compressed_texture_astc_ldr"? Then again I'm also not sure if I
understand what the interface differences between the hdr/ldr extensions are. It
looks like they both expose the same format enums? Could you clarify how
developers use the two?

+}
+
+} // namespace blink