Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1265663002: Assign more bits to safepoint table offset. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Assign more bits to safepoint table offset. 1 << 24 is apparently not large enough for some optimized code. R=jkummerow@chromium.org BUG=v8:4272 LOG=N Committed: https://crrev.com/39bcda21ff3c1fd106f3bf501e57c9fc96620a17 Cr-Commit-Position: refs/heads/master@{#29909}

Patch Set 1 #

Patch Set 2 : change to 30 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.h View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Yang
5 years, 4 months ago (2015-07-29 14:51:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265663002/1
5 years, 4 months ago (2015-07-29 14:51:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/4845)
5 years, 4 months ago (2015-07-29 15:00:06 UTC) #5
Jakob Kummerow
LGTM. Thankfully the STATIC_ASSERT on the next line says that this change is safe :-)
5 years, 4 months ago (2015-07-29 16:19:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265663002/20001
5 years, 4 months ago (2015-07-30 06:04:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 08:17:19 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 08:17:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39bcda21ff3c1fd106f3bf501e57c9fc96620a17
Cr-Commit-Position: refs/heads/master@{#29909}

Powered by Google App Engine
This is Rietveld 408576698