Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1265603002: MIPS64: Fix the integer division in crankshaft. (Closed)

Created:
5 years, 4 months ago by akos.palfi.imgtec
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix the integer division in crankshaft. Replaces the 64-bit div instruction with 32-bit division in DivI. Also fixes the Ddiv implementation in the simulator. TEST=mjsunit/asm/int32div BUG= Committed: https://crrev.com/437c789a26960e6902fe7f905c6b7dc5784c8c9b Cr-Commit-Position: refs/heads/master@{#29920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 4 months ago (2015-07-29 11:15:14 UTC) #2
dusmil.imgtec
lgtm.
5 years, 4 months ago (2015-07-29 19:05:31 UTC) #3
paul.l...
LGTM, thanks.
5 years, 4 months ago (2015-07-29 19:21:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265603002/1
5 years, 4 months ago (2015-07-29 20:03:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 09:16:21 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-30 09:16:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/437c789a26960e6902fe7f905c6b7dc5784c8c9b
Cr-Commit-Position: refs/heads/master@{#29920}

Powered by Google App Engine
This is Rietveld 408576698