Fix issue 23942 by updating expectations.

runtime/vm/thread_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/isolate.h"
 #include "vm/lockers.h"
 #include "vm/unit_test.h"
 #include "vm/profiler.h"
 #include "vm/thread_pool.h"
@@ skipping 253 matching lines @@
 
   virtual void Run() {
     Thread::EnterIsolateAsHelper(isolate_);
     {
       MutexLocker ml(mutex_);
       ++*expected_count_;
     }
     for (int i = 0; ; ++i) {
       Thread* thread = Thread::Current();
       StackZone stack_zone(thread);
-        Zone* zone = thread->zone();
-        HANDLESCOPE(thread);
-        const intptr_t kUniqueSmi = 928327281;
-        Smi& smi = Smi::Handle(zone, Smi::New(kUniqueSmi));
-        if ((i % 100) != 0) {
-          // Usually, we just cooperate.
-          isolate_->thread_registry()->CheckSafepoint();
-        } else {
-          // But occasionally, organize a rendezvous.
-          isolate_->thread_registry()->SafepointThreads();
-          ObjectCounter counter(isolate_, &smi);
-          isolate_->thread_registry()->VisitObjectPointers(&counter);
-          {
-            MutexLocker ml(mutex_);
-            EXPECT_EQ(*expected_count_, counter.count());
-          }
-          UserTag& tag = UserTag::Handle(zone, isolate_->current_tag());
-          if (tag.raw() != isolate_->default_tag()) {
-            String& label = String::Handle(zone, tag.label());
-            EXPECT(label.Equals("foo"));
-            // if this is the first time.
-            MutexLocker ml(mutex_);
-            if (*expected_count_ == kTaskCount && !local_done_) {
-              // Success for the first time! Remember that we are done, and
-              // update the total count.
-              local_done_ = true;
-              ++*total_done_;
-            }
-          }
-          isolate_->thread_registry()->ResumeAllThreads();
-        }
-        // Check whether everyone is done.
+      Zone* zone = thread->zone();
+      HANDLESCOPE(thread);
+      const intptr_t kUniqueSmi = 928327281;
+      Smi& smi = Smi::Handle(zone, Smi::New(kUniqueSmi));
+      if ((i % 100) != 0) {
+        // Usually, we just cooperate.
+        isolate_->thread_registry()->CheckSafepoint();
+      } else {
+        // But occasionally, organize a rendezvous.
+        isolate_->thread_registry()->SafepointThreads();
+        ObjectCounter counter(isolate_, &smi);
+        isolate_->thread_registry()->VisitObjectPointers(&counter);
         {
           MutexLocker ml(mutex_);
-          if (*total_done_ == kTaskCount) {
-            break;
+          EXPECT_EQ(*expected_count_, counter.count());
+        }
+        UserTag& tag = UserTag::Handle(zone, isolate_->current_tag());
+        if (tag.raw() != isolate_->default_tag()) {
+          String& label = String::Handle(zone, tag.label());
+          EXPECT(label.Equals("foo"));

[Ivan Posva, 2015/08/03 16:07:46]

Isn't this a potential source for flaky failures due to the fact that the Dart
thread might execute any other code such as compilation when it is interrupted?

[koda, 2015/08/03 16:15:47]

Compilation changes the VM tag, not the user tag. The latter should remain
"foo".

+          MutexLocker ml(mutex_);
+          if (*expected_count_ == kTaskCount && !local_done_) {
+            // Success for the first time! Remember that we are done, and
+            // update the total count.
+            local_done_ = true;
+            ++*total_done_;
           }
         }
+        isolate_->thread_registry()->ResumeAllThreads();

[Ivan Posva, 2015/08/03 16:07:46]

Is there a surviving All here?

[koda, 2015/08/03 16:15:47]

Yes. I can rename it in a future CL.

+      }
+      // Check whether everyone is done.
+      {
+        MutexLocker ml(mutex_);
+        if (*total_done_ == kTaskCount) {
+          // Another task might be at SafepointThreads when resuming. Ensure its
+          // expectation reflects reality, since we pop our handles here.
+          --*expected_count_;
+          break;
+        }
+      }
     }
     Thread::ExitIsolateAsHelper();
     {
       MutexLocker ml(mutex_);
       ++*exited_;
     }
   }
 
  private:
   Isolate* isolate_;
@@ skipping 118 matching lines @@
   while (true) {
     isolate->thread_registry()->CheckSafepoint();
     MutexLocker ml(&mutex);
     if (exited == SafepointTestTask::kTaskCount) {
       break;
     }
   }
 }
 
 }  // namespace dart