Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1265503002: win 2015: Update the toolchain package to VS2015 RTM. (Closed)

Created:
5 years, 4 months ago by Sébastien Marchand
Modified:
5 years, 4 months ago
Reviewers:
Nico, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win 2015: Update the toolchain package to VS2015 RTM. I've tried it locally (build Chrome with this archive on a fresh VM) and it worked well, the archive has been generated with package_from_installed.py (from depot_tools/win_toolchain) BUG=440500 Committed: https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa Cr-Commit-Position: refs/heads/master@{#340898} Committed: https://crrev.com/21f280ff2c7838a748b7aa93391164fcd185d53b Cr-Commit-Position: refs/heads/master@{#341146}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/vs_toolchain.py View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
Sébastien Marchand
PTAL.
5 years, 4 months ago (2015-07-28 20:40:42 UTC) #2
Sébastien Marchand
Just realized that you're not an owner for this, +thakis@ for owner approval.
5 years, 4 months ago (2015-07-28 20:43:50 UTC) #4
Nico
is https://code.google.com/p/chromium/issues/detail?id=498544 fixed?
5 years, 4 months ago (2015-07-28 20:45:12 UTC) #5
Sébastien Marchand
I don't know, I'll check locally and I'll let you know
5 years, 4 months ago (2015-07-28 20:48:54 UTC) #6
Sébastien Marchand
I don't think that this bug should prevent us from switching from the RC to ...
5 years, 4 months ago (2015-07-28 20:53:08 UTC) #7
Nico
Ah right. lgtm then.
5 years, 4 months ago (2015-07-28 20:53:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265503002/20001
5 years, 4 months ago (2015-07-29 16:33:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-29 16:44:19 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa Cr-Commit-Position: refs/heads/master@{#340898}
5 years, 4 months ago (2015-07-29 16:44:52 UTC) #13
Sébastien Marchand
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1254023004/ by sebmarchand@chromium.org. ...
5 years, 4 months ago (2015-07-29 17:03:19 UTC) #14
Sébastien Marchand
I've installed the VS2015 redistribuables on the bot, relanding this to fix the debug builder.
5 years, 4 months ago (2015-07-30 17:14:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265503002/20001
5 years, 4 months ago (2015-07-30 17:15:21 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-07-30 17:24:50 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/21f280ff2c7838a748b7aa93391164fcd185d53b Cr-Commit-Position: refs/heads/master@{#341146}
5 years, 4 months ago (2015-07-30 17:25:33 UTC) #19
brucedawson
This should have had BUG=440500 in order to associate it with the VS 2015 bug ...
5 years, 4 months ago (2015-08-03 18:47:05 UTC) #20
scottmg
5 years, 4 months ago (2015-08-07 20:33:43 UTC) #21
Message was sent while issue was closed.
On 2015/07/30 17:14:17, Sébastien Marchand wrote:
> I've installed the VS2015 redistribuables on the bot, relanding this to fix
the
> debug builder.

Ideally we wouldn't be installing redists on bots. I don't want to have to deal
with that on every new VM.

Powered by Google App Engine
This is Rietveld 408576698