|
|
Created:
5 years, 4 months ago by Sébastien Marchand Modified:
5 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionwin 2015: Update the toolchain package to VS2015 RTM.
I've tried it locally (build Chrome with this archive on a fresh VM) and it worked well, the archive has been generated with package_from_installed.py (from depot_tools/win_toolchain)
BUG=440500
Committed: https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa
Cr-Commit-Position: refs/heads/master@{#340898}
Committed: https://crrev.com/21f280ff2c7838a748b7aa93391164fcd185d53b
Cr-Commit-Position: refs/heads/master@{#341146}
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 21 (5 generated)
sebmarchand@chromium.org changed reviewers: + brucedawson@chromium.org
PTAL.
sebmarchand@chromium.org changed reviewers: + thakis@chromium.org
Just realized that you're not an owner for this, +thakis@ for owner approval.
I don't know, I'll check locally and I'll let you know
I don't think that this bug should prevent us from switching from the RC to the RTM, we just won't switch the default toolchain to VS2015.
Ah right. lgtm then.
The CQ bit was checked by sebmarchand@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/1265503002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265503002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f04ff85d2b85833971ef7ca7f31f4fd5a1b1f3aa Cr-Commit-Position: refs/heads/master@{#340898}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1254023004/ by sebmarchand@chromium.org. The reason for reverting is: It's breaking the VS2015 builder. I'm looking at it..
Message was sent while issue was closed.
I've installed the VS2015 redistribuables on the bot, relanding this to fix the debug builder.
The CQ bit was checked by sebmarchand@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265503002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265503002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/21f280ff2c7838a748b7aa93391164fcd185d53b Cr-Commit-Position: refs/heads/master@{#341146}
Message was sent while issue was closed.
This should have had BUG=440500 in order to associate it with the VS 2015 bug - I missed that earlier. The debug builder is now failing for a different reason: > Failed to find an input file: Input file C:\b\build\slave\chromium-dbg-builder\build\src\out\Debug\msvcp120d.dll doesn't exist I'm going to put this information in the bug as well.
Message was sent while issue was closed.
On 2015/07/30 17:14:17, Sébastien Marchand wrote: > I've installed the VS2015 redistribuables on the bot, relanding this to fix the > debug builder. Ideally we wouldn't be installing redists on bots. I don't want to have to deal with that on every new VM. |