Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1265443002: add -Iinclude/private anywhere we have -Isrc/core (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add -Iinclude/private anywhere we have -Isrc/core I'll be moving headers from src/core to include/private, so this guarantees that anyone who was finding them via -Isrc/core can now find them via -Iinclude/private. This is purely mechanical, mostly to preserve my sanity, so it's likely (harmless) overkill. Chromium's GYP and GN builds already set -Iinclude/private for Skia builds. BUG=skia:4126 Committed: https://skia.googlesource.com/skia/+/cd1f2daf44c3cff541984378765d80d7166f33b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/codec.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/dm.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/effects.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/flags.gyp View 1 chunk +4 lines, -1 line 0 comments Download
M gyp/gpu.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gputest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/images.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/ktx.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/opts.gyp View 4 chunks +10 lines, -1 line 0 comments Download
M gyp/pathops_skpclip.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/pathops_unittest.gypi View 2 chunks +3 lines, -2 lines 0 comments Download
M gyp/pdf.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/pdfviewer_lib.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/ports.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/svg.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/visualbench.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M gyp/xps.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265443002/1
5 years, 4 months ago (2015-07-28 15:13:51 UTC) #2
mtklein_C
5 years, 4 months ago (2015-07-28 15:14:25 UTC) #4
bungeman-skia
lgtm
5 years, 4 months ago (2015-07-28 15:50:23 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-28 15:53:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265443002/1
5 years, 4 months ago (2015-07-28 15:54:27 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 15:55:18 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/cd1f2daf44c3cff541984378765d80d7166f33b0

Powered by Google App Engine
This is Rietveld 408576698