Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: tools/perf/page_sets/PRESUBMIT.py

Issue 126543006: Fix cloud storage upload messages in page_sets/PRESUBMIT.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/PRESUBMIT.py
diff --git a/tools/perf/page_sets/PRESUBMIT.py b/tools/perf/page_sets/PRESUBMIT.py
index f75a39638367d6554e3b1c06056c803f66ea2819..2e02e423a6ca7d4aeba60f28b9d3fe3fd3064d9c 100644
--- a/tools/perf/page_sets/PRESUBMIT.py
+++ b/tools/perf/page_sets/PRESUBMIT.py
@@ -80,8 +80,9 @@ def _SyncFilesToCloud(input_api, output_api):
continue
try:
- bucket_input = raw_input('Uploading to Cloud Storage: %s\nIs this file '
- '[p]ublic or Google-[i]nternal?').lower()
+ bucket_input = raw_input('Uploading to Cloud Storage: %s\n'
+ 'Is this file [p]ublic or Google-[i]nternal?'
+ % file_path).lower()
if 'public'.startswith(bucket_input):
bucket = cloud_storage.PUBLIC_BUCKET
elif ('internal'.startswith(bucket_input) or
@@ -94,10 +95,10 @@ def _SyncFilesToCloud(input_api, output_api):
cloud_storage.Insert(bucket, file_hash, file_path)
results.append(output_api.PresubmitNotifyResult(
- 'Uploaded file to Cloud Storage: %s' % hash_path))
+ 'Uploaded file to Cloud Storage: %s' % file_path))
except cloud_storage.CloudStorageError, e:
results.append(output_api.PresubmitError(
- 'Unable to upload to Cloud Storage: %s\n\n%s' % (hash_path, e)))
+ 'Unable to upload to Cloud Storage: %s\n\n%s' % (file_path, e)))
return results
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698