Issue 126543006: Fix cloud storage upload messages in page_sets/PRESUBMIT.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126543006: Fix cloud storage upload messages in page_sets/PRESUBMIT.py (Closed)

Created:
6 years, 11 months ago by adamk

Modified:
6 years, 11 months ago

Reviewers:
dtu

CC:
chromium-reviews, chrome-speed-team+watch_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix cloud storage upload messages in page_sets/PRESUBMIT.py The public/internal prompt had an unexpanded "%s" replacement. Also, messages about what was being uploaded referred to the sha1 file, while the thing actually being uploaded is the .wpr. R=dtu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243645

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	tools/perf/page_sets/PRESUBMIT.py	View		2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/126543006/1

6 years, 11 months ago (2014-01-08 21:06:48 UTC) #3

adamk

6 years, 11 months ago (2014-01-08 21:07:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r243645 (presubmit successful).

Expand Messages | Collapse Messages