Issue 126543005: Fix QUIC faster stats reporting memory leaks and crashes by changing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126543005: Fix QUIC faster stats reporting memory leaks and crashes by changing (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)

Modified:
6 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix QUIC faster stats reporting memory leaks and crashes by changing lifetime once again. Now QuicAckNotify::DelegateInterface, one of the base classes of QuicFasterStatsGatherer, is ref-counted so QuicFasterStatsGatherer is guanrateed to be around until either faster stats reporting happens or the last ack is delivered by the QuicConnection. Merge internal change: 59228960 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -26 lines)			Patch
M	net/quic/quic_ack_notifier.h	View	3 chunks	+11 lines, -3 lines	0 comments	Download
M	net/quic/quic_ack_notifier.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_ack_notifier_test.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	net/tools/quic/test_tools/quic_test_utils.h	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages