Issue 126543004: Revert of Mirror images for RTL languages at build time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126543004: Revert of Mirror images for RTL languages at build time. (Closed)

Created:
6 years, 11 months ago by newt (away)

Modified:
6 years, 11 months ago

Reviewers:
cjhopman, Kibeom Kim (inactive), pschmidt1

CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, shashi

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/106173002/ Reason for revert: this introduced a package dependency bug where ia32-libs cannot be installed on ubuntu precise systems TBR=kkimlabs@chromium.org,cjhopman@chromium.org,pschmidt@chromium.org NOTREECHECKS=true NOTRY=true BUG=290225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243437

Patch Set 1 #

Created: 6 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -345 lines)			Patch
D	build/android/gyp/mirror_images.py	View	1 chunk	+0 lines, -278 lines	0 comments	Download
M	build/android/gyp/process_resources.py	View	6 chunks	+12 lines, -38 lines	0 comments	Download
M	build/install-build-deps-android.sh	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	build/java.gypi	View	3 chunks	+2 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

newt (away)

Created Revert of Mirror images for RTL languages at build time.

6 years, 11 months ago (2014-01-07 23:58:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/126543004/1

6 years, 11 months ago (2014-01-08 00:02:59 UTC) #2

Message was sent while issue was closed.

Change committed as 243437

Expand Messages | Collapse Messages