Chromium Code Reviews| Index: src/heap/gc-idle-time-handler.h |
| diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h |
| index 8f12a446f2a1609276cf8310f1e06030738dedc7..ebaefc336109b3de8d8386e12511a0f63975bf04 100644 |
| --- a/src/heap/gc-idle-time-handler.h |
| +++ b/src/heap/gc-idle-time-handler.h |
| @@ -13,10 +13,9 @@ namespace internal { |
| enum GCIdleTimeActionType { |
| DONE, |
| DO_NOTHING, |
| - DO_INCREMENTAL_MARKING, |
| + DO_INCREMENTAL_STEP, |
|
ulan
2015/08/05 11:11:59
DO_INCREMENTAL_MARKING and DO_FINALIZE_SWEEPING ar
Hannes Payer (out of office)
2015/08/05 12:35:44
SGTM
|
| DO_SCAVENGE, |
| DO_FULL_GC, |
| - DO_FINALIZE_SWEEPING |
| }; |
| @@ -25,7 +24,6 @@ class GCIdleTimeAction { |
| static GCIdleTimeAction Done() { |
| GCIdleTimeAction result; |
| result.type = DONE; |
| - result.parameter = 0; |
| result.additional_work = false; |
| return result; |
| } |
| @@ -33,15 +31,13 @@ class GCIdleTimeAction { |
| static GCIdleTimeAction Nothing() { |
| GCIdleTimeAction result; |
| result.type = DO_NOTHING; |
| - result.parameter = 0; |
| result.additional_work = false; |
| return result; |
| } |
| - static GCIdleTimeAction IncrementalMarking(intptr_t step_size) { |
| + static GCIdleTimeAction IncrementalStep() { |
| GCIdleTimeAction result; |
| - result.type = DO_INCREMENTAL_MARKING; |
| - result.parameter = step_size; |
| + result.type = DO_INCREMENTAL_STEP; |
| result.additional_work = false; |
| return result; |
| } |
| @@ -49,7 +45,6 @@ class GCIdleTimeAction { |
| static GCIdleTimeAction Scavenge() { |
| GCIdleTimeAction result; |
| result.type = DO_SCAVENGE; |
| - result.parameter = 0; |
| result.additional_work = false; |
| return result; |
| } |
| @@ -57,15 +52,6 @@ class GCIdleTimeAction { |
| static GCIdleTimeAction FullGC() { |
| GCIdleTimeAction result; |
| result.type = DO_FULL_GC; |
| - result.parameter = 0; |
| - result.additional_work = false; |
| - return result; |
| - } |
| - |
| - static GCIdleTimeAction FinalizeSweeping() { |
| - GCIdleTimeAction result; |
| - result.type = DO_FINALIZE_SWEEPING; |
| - result.parameter = 0; |
| result.additional_work = false; |
| return result; |
| } |
| @@ -73,7 +59,6 @@ class GCIdleTimeAction { |
| void Print(); |
| GCIdleTimeActionType type; |
| - intptr_t parameter; |
|
ulan
2015/08/05 11:11:59
This is gone because we estimate the step size out
Hannes Payer (out of office)
2015/08/05 12:35:44
ack
|
| bool additional_work; |
| }; |