Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1265403003: Fix HistogramTester::GetAllSamples when empty. (Closed)

Created:
5 years, 4 months ago by twifkak
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix HistogramTester::GetAllSamples when empty. Fix GetAllSamples to return an empty vector when the histogram has no samples, instead of crashing. BUG= Committed: https://crrev.com/36a9d6f54d27a5a093b8520a4015e8ec1a7c06bd Cr-Commit-Position: refs/heads/master@{#342634}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M base/test/histogram_tester.cc View 1 chunk +7 lines, -5 lines 2 comments Download
M base/test/histogram_tester_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
twifkak
5 years, 4 months ago (2015-08-06 23:24:10 UTC) #2
Ilya Sherman
LGTM, thanks. https://codereview.chromium.org/1265403003/diff/1/base/test/histogram_tester.cc File base/test/histogram_tester.cc (right): https://codereview.chromium.org/1265403003/diff/1/base/test/histogram_tester.cc#newcode82 base/test/histogram_tester.cc:82: if (snapshot) { optional nit: I'd write ...
5 years, 4 months ago (2015-08-07 17:20:12 UTC) #3
twifkak
https://codereview.chromium.org/1265403003/diff/1/base/test/histogram_tester.cc File base/test/histogram_tester.cc (right): https://codereview.chromium.org/1265403003/diff/1/base/test/histogram_tester.cc#newcode82 base/test/histogram_tester.cc:82: if (snapshot) { On 2015/08/07 17:20:12, Ilya Sherman wrote: ...
5 years, 4 months ago (2015-08-07 19:36:38 UTC) #4
Paweł Hajdan Jr.
LGTM
5 years, 4 months ago (2015-08-10 12:59:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265403003/1
5 years, 4 months ago (2015-08-10 15:34:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-10 16:39:38 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 16:40:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36a9d6f54d27a5a093b8520a4015e8ec1a7c06bd
Cr-Commit-Position: refs/heads/master@{#342634}

Powered by Google App Engine
This is Rietveld 408576698