Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Issue 1265383006: Revert of Re-enable ChannelMojo (Closed)

Created:
5 years, 4 months ago by hiroshige
Modified:
5 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unfuck-everything
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable ChannelMojo (patchset #1 id:20001 of https://codereview.chromium.org/1262503011/ ) Reason for revert: Suspecting this CL causes many Layout test failures (https://crbug.com/517391). Original issue's description: > Re-enable ChannelMojo > > The performance regression seen previously was probably > misattributed to ChannelMojo. Also, given that a great deal of > code will now take advantage of the channel's thread-safe Send, > this is expected to result in an net performance improvement. > > BUG=500019 > TBR=jam@chromium.org > > Committed: https://crrev.com/ab1a53c964a77dabb6d08b7199111b51a330885e > Cr-Commit-Position: refs/heads/master@{#342055} TBR=rockot@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500019 Committed: https://crrev.com/a116e2287895078d72b2766ab1ac44582b27a7c6 Cr-Commit-Position: refs/heads/master@{#342085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hiroshige
Created Revert of Re-enable ChannelMojo
5 years, 4 months ago (2015-08-06 09:27:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265383006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265383006/1
5 years, 4 months ago (2015-08-06 09:27:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 09:28:21 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 09:29:06 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a116e2287895078d72b2766ab1ac44582b27a7c6
Cr-Commit-Position: refs/heads/master@{#342085}

Powered by Google App Engine
This is Rietveld 408576698