Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Issue 1265373003: Disable ENABLE_BITCODE for iOS 9. (Closed)

Created:
5 years, 4 months ago by Olivier
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ENABLE_BITCODE for iOS 9. We don't support bitcode yet and open source version of clang does not support the embed-bitcode-marker flag. Turn off bitcode at the moment. BUG=516530 Committed: https://crrev.com/628601cd3665668cc197b3c3b4f56bba68b131ae Cr-Commit-Position: refs/heads/master@{#342316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Olivier
5 years, 4 months ago (2015-08-05 11:24:57 UTC) #2
sdefresne
lgtm
5 years, 4 months ago (2015-08-05 12:29:05 UTC) #3
justincohen
dpranke or scottmg for OWNERS.
5 years, 4 months ago (2015-08-06 20:39:50 UTC) #5
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-06 20:40:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265373003/1
5 years, 4 months ago (2015-08-06 20:44:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/87631)
5 years, 4 months ago (2015-08-06 21:53:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265373003/1
5 years, 4 months ago (2015-08-07 07:06:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 07:46:47 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 07:47:26 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/628601cd3665668cc197b3c3b4f56bba68b131ae
Cr-Commit-Position: refs/heads/master@{#342316}

Powered by Google App Engine
This is Rietveld 408576698