Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: lib/src/runner/browser/dartium.dart

Issue 1265333002: Only fetch the Observatory URL in debug mode. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/content_shell.dart ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/dartium.dart
diff --git a/lib/src/runner/browser/dartium.dart b/lib/src/runner/browser/dartium.dart
index 8e6a8a30c6431d2b6f10ed80ca7e98a4332a8a72..b7ae86f68c0bf7f2a309b93e5eb96cafbc23eb7e 100644
--- a/lib/src/runner/browser/dartium.dart
+++ b/lib/src/runner/browser/dartium.dart
@@ -30,7 +30,7 @@ class Dartium extends Browser {
final Future<Uri> observatoryUrl;
- factory Dartium(url, {String executable}) {
+ factory Dartium(url, {String executable, bool debug: false}) {
var completer = new Completer.sync();
return new Dartium._(() async {
if (executable == null) executable = _defaultExecutable();
@@ -48,9 +48,11 @@ class Dartium extends Browser {
"--disable-translate"
], environment: {"DART_FLAGS": "--checked"});
- // The first observatory URL emitted is for the empty start page; the
- // second is actually for the host page.
- completer.complete(_getObservatoryUrl(process.stdout));
+ if (debug) {
+ completer.complete(_getObservatoryUrl(process.stdout));
+ } else {
+ completer.complete(null);
+ }
process.exitCode
.then((_) => new Directory(dir).deleteSync(recursive: true));
« no previous file with comments | « lib/src/runner/browser/content_shell.dart ('k') | lib/src/runner/browser/server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698