Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: test/mjsunit/array-unshift.js

Issue 12653010: Fix %GetArrayKeys to not skip non-enumerable indices (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Handle review comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/array-shift.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 } 206 }
207 })(); 207 })();
208 208
209 (function() { 209 (function() {
210 for (var i = 0; i < 7; i++) { 210 for (var i = 0; i < 7; i++) {
211 var a = [6, 7, 8, 9]; 211 var a = [6, 7, 8, 9];
212 a.unshift(1, 2, 3, 4, 5); 212 a.unshift(1, 2, 3, 4, 5);
213 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a); 213 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a);
214 } 214 }
215 })(); 215 })();
216
217 // Check that non-enumerable elements are treated appropriately
218 (function() {
219 var array = [2, 3];
220 Object.defineProperty(array, '1', {enumerable: false});
221 array.unshift(1)
222 assertEquals([1, 2, 3], array);
223
224 array = [2];
225 array.length = 2;
226 array.__proto__[1] = 3;
227 Object.defineProperty(array.__proto__, '1', {enumerable: false});
228 array.unshift(1);
229 assertEquals([1, 2, 3], array);
230 })();
OLDNEW
« no previous file with comments | « test/mjsunit/array-shift.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698