More useful result pretty printing for d8

More useful result pretty printing for d8

For example:

d8> ["hi", 5, [2,3],Object.prototype.toString, {get a() { return a}, b: 9, set a(x) {this.b=x}}, null, undefined]
["hi", 5, [2, 3], function toString() { [native code] }, {get a() { return a}, set a(x) {this.b=x}, b: 9}, null, undefined]

Deactivated in test mode.

R=yangguo@chromium.org
BUG=

Committed: http://code.google.com/p/v8/source/detail?r=13966

[Yang, 2013-03-12 12:56:35]

On 2013/03/08 15:07:43, rossberg wrote:

LGTM with comments.

[Yang, 2013-03-12 12:56:41]

https://codereview.chromium.org/12653003/diff/1/src/d8.js
File src/d8.js (right):

https://codereview.chromium.org/12653003/diff/1/src/d8.js#newcode2201
src/d8.js:2201: var stringifyDepthLimit = 12;  // To avoid crashing on cyclic
objects
You could also use a stack to detect cycles.

https://codereview.chromium.org/12653003/diff/1/src/d8.js#newcode2222
src/d8.js:2222: elems.push(x.hasOwnProperty(i) ? Stringify(x[i], depth - 1) :
"");
Would it make sense to try to avoid monkey-patched methods? %ArrayPush probably
works. Or use InternalArray.

[rossberg, 2013-03-18 14:03:07]

https://codereview.chromium.org/12653003/diff/1/src/d8.js
File src/d8.js (right):

https://codereview.chromium.org/12653003/diff/1/src/d8.js#newcode2201
src/d8.js:2201: var stringifyDepthLimit = 12;  // To avoid crashing on cyclic
objects
On 2013/03/12 12:56:41, Yang wrote:
> You could also use a stack to detect cycles.

I'd need an object set to do it properly, which I want to avoid relying on for
the time being. Future work.

https://codereview.chromium.org/12653003/diff/1/src/d8.js#newcode2222
src/d8.js:2222: elems.push(x.hasOwnProperty(i) ? Stringify(x[i], depth - 1) :
"");
On 2013/03/12 12:56:41, Yang wrote:
> Would it make sense to try to avoid monkey-patched methods? %ArrayPush
probably
> works. Or use InternalArray.

There are many ways in which this code could break if you monkey patch
inproperly. I don't feel an urge to protect against all of it. I did, however,
replace x.hasOwnProperty with {}.hasOwnProperty.call, so that it works on
objects with strange prototypes.

[Toon Verwaest, 2013-03-18 15:28:58]

This CL breaks building V8 as shared library. (component=shared_library).

[rossberg, 2013-03-18 15:46:37]

On 2013/03/18 15:28:58, Toon Verwaest wrote:
> This CL breaks building V8 as shared library. (component=shared_library).

Fix under https://codereview.chromium.org/12779019/