Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1265273002: Reland: GC: Refactor public incremental marking interface in heap (Closed)

Created:
5 years, 4 months ago by Michael Lippautz
Modified:
5 years, 4 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: GC: Refactor public incremental marking interface in heap Combines: * https://codereview.chromium.org/1273483002/ * https://codereview.chromium.org/1266793003/ This reverts commit 0215fb56f4c75b054116632039edbff0d7f40373. BUG= Committed: https://crrev.com/9d7ebcf7f508b987464575b481476ce0a49d98b1 Cr-Commit-Position: refs/heads/master@{#30014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -19 lines) Patch
M src/heap/heap.h View 2 chunks +15 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +28 lines, -10 lines 0 comments Download
M src/heap/incremental-marking.h View 4 chunks +22 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 4 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Lippautz
5 years, 4 months ago (2015-08-04 18:08:18 UTC) #2
ulan
lgtm
5 years, 4 months ago (2015-08-04 18:20:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265273002/1
5 years, 4 months ago (2015-08-04 18:29:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 19:01:05 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 19:01:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d7ebcf7f508b987464575b481476ce0a49d98b1
Cr-Commit-Position: refs/heads/master@{#30014}

Powered by Google App Engine
This is Rietveld 408576698