build/config/linux/pkg_config.gni - Issue 1265263002: Use new GN features in the build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/linux/pkg_config.gni

Issue 1265263002: Use new GN features in the build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/linux/pkg_config.gni

diff --git a/build/config/linux/pkg_config.gni b/build/config/linux/pkg_config.gni

index 34ed1afa17c1ce004aa461bab258c564b23d91bb..914ca8d6e728ae8eb3826e760246c6561fe28df6 100644

--- a/build/config/linux/pkg_config.gni

+++ b/build/config/linux/pkg_config.gni

@@ -73,11 +73,10 @@ template("pkg_config") {

ldflags = pkgresult[4]

}

- if (defined(invoker.defines)) {

- defines = invoker.defines

- }

- if (defined(invoker.visibility)) {

- visibility = invoker.visibility

- }

+ forward_variables_from(invoker,

+ [

+ "defines",

+ "visibility",

+ ])

Dirk Pranke 2015/08/04 18:19:22 it's a bit goofy that this is five lines instead o

brettw 2015/08/04 19:10:25 I agree, we should fix the autoformatter at some p

}