Componentize profile_sync_auth_provider

Componentize profile_sync_auth_provider

Moving profile_sync_auth_provider to sync_driver.

BUG=512074
Committed: https://crrev.com/6f34b5dd1ddb5db3b8c86140a7b830a316bc1414
Cr-Commit-Position: refs/heads/master@{#341897}

[Abhishek, 2015-08-04 06:57:07]

abhishek.a21@samsung.com changed reviewers:
+ droger@chromium.org, r.kasibhatla@samsung.com

[Abhishek, 2015-08-04 06:57:07]

PTAL!

[droger, 2015-08-04 07:58:43]

droger@chromium.org changed reviewers:
+ rogerta@chromium.org, zea@chromium.org

[droger, 2015-08-04 07:58:44]

Thank you.
LGTM, assuming the comments below are adressed.

+zea as owner for components/sync_driver
+rogerta for the new dep on components/signin/core/browser

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver.gypi
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver.gypi...
components/sync_driver.gypi:14: 'os_crypt',
Please add
'signin_core_browser',

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver/BUIL...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver/BUIL...
components/sync_driver/BUILD.gn:75: "//components/os_crypt",
Can you update the deps here? You need to add //components/signin/core/browser
at least

[Abhishek, 2015-08-04 08:46:52]

Updated dependencies for .gypi and .gn files.

PTAL!

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver.gypi
File components/sync_driver.gypi (right):

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver.gypi...
components/sync_driver.gypi:14: 'os_crypt',
On 2015/08/04 07:58:43, droger wrote:
> Please add
> 'signin_core_browser',

Done.

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver/BUIL...
File components/sync_driver/BUILD.gn (right):

https://codereview.chromium.org/1265213003/diff/1/components/sync_driver/BUIL...
components/sync_driver/BUILD.gn:75: "//components/os_crypt",
On 2015/08/04 07:58:43, droger wrote:
> Can you update the deps here? You need to add //components/signin/core/browser
> at least

Done.

[droger, 2015-08-04 08:52:43]

On 2015/08/04 08:46:52, Abhishek wrote:
> Updated dependencies for .gypi and .gn files.
> 
> PTAL!

Thanks!

[Roger Tawa OOO till Jul 10th, 2015-08-04 15:49:32]

lgtm deps in signin

[Nicolas Zea, 2015-08-04 17:18:56]

LGTM

[Abhishek, 2015-08-05 04:00:17]

The CQ bit was checked by abhishek.a21@samsung.com

[Abhishek, 2015-08-05 04:00:18]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org
Link to the patchset: https://codereview.chromium.org/1265213003/#ps20001
(title: "updated dependencies")

[commit-bot: I haz the power, 2015-08-05 04:00:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265213003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265213003/20001

[commit-bot: I haz the power, 2015-08-05 05:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 05:49:06]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Abhishek, 2015-08-05 12:05:41]

This patch failed for below test case.
--
[  FAILED  ] TraceTest.WebGLGreenTriangle (1273 ms)

over "mac_chromium_rel_ng -> trace_test on NVIDIA GPU on Mac Retina"

Please help me how to check it further!

[blundell, 2015-08-05 12:07:13]

On 2015/08/05 12:05:41, Abhishek wrote:
> This patch failed for below test case.
> --
> [  FAILED  ] TraceTest.WebGLGreenTriangle (1273 ms)
> 
> over "mac_chromium_rel_ng -> trace_test on NVIDIA GPU on Mac Retina"
> 
> Please help me how to check it further!

That's flake (unfortunately) -- just retry. (Same is true with the
win_chromium_rel_ng failures).

[droger, 2015-08-05 12:07:13]

On 2015/08/05 12:05:41, Abhishek wrote:
> This patch failed for below test case.
> --
> [  FAILED  ] TraceTest.WebGLGreenTriangle (1273 ms)
> 
> over "mac_chromium_rel_ng -> trace_test on NVIDIA GPU on Mac Retina"
> 
> Please help me how to check it further!

This looks like a flake. I would just try again and see if it works.

[Abhishek, 2015-08-05 12:19:16]

The CQ bit was checked by abhishek.a21@samsung.com

[commit-bot: I haz the power, 2015-08-05 12:19:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265213003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265213003/20001

[commit-bot: I haz the power, 2015-08-05 14:02:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-05 14:02:57]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[droger, 2015-08-05 14:06:27]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-08-05 14:06:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1265213003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1265213003/20001

[commit-bot: I haz the power, 2015-08-05 14:54:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-05 14:55:26]

Patchset 2 (id:??) landed as
https://crrev.com/6f34b5dd1ddb5db3b8c86140a7b830a316bc1414
Cr-Commit-Position: refs/heads/master@{#341897}