Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1265203002: Convert autocomplete attribute values to constants (Closed)

Created:
5 years, 4 months ago by ramya.v
Modified:
5 years, 4 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, vabr+watchlist_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert autocomplete attribute values to constants BUG=514123 To avoid typos in the code this patch converts autocomplete attribute values to constants. Committed: https://crrev.com/d34042912daf7277cf5f0c6d890be6b0ca54f8cd Cr-Commit-Position: refs/heads/master@{#341703}

Patch Set 1 #

Patch Set 2 : Rebasing file #

Patch Set 3 : Rebasing to latest code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 2 5 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ramya.v
Hi Vaclav PTAL! Thanks
5 years, 4 months ago (2015-08-04 07:27:57 UTC) #2
vabr (Chromium)
LGTM, thank you! Vaclav
5 years, 4 months ago (2015-08-04 07:45:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265203002/40001
5 years, 4 months ago (2015-08-04 07:47:34 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-04 09:23:38 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 09:24:14 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d34042912daf7277cf5f0c6d890be6b0ca54f8cd
Cr-Commit-Position: refs/heads/master@{#341703}

Powered by Google App Engine
This is Rietveld 408576698