[1/3 blink] Support redirect option of Request and "opaqueredirect" response type.

Source/modules/serviceworkers/RespondWithObserver.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/serviceworkers/RespondWithObserver.h"
 
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptValue.h"
@@ skipping 36 matching lines @@
         break;
     case WebServiceWorkerResponseErrorResponseTypeNotBasicOrDefault:
         ASSERT_NOT_REACHED();
         break;
     case WebServiceWorkerResponseErrorBodyUsed:
         errorMessage = errorMessage + "a Response whose \"bodyUsed\" is \"true\" cannot be used to respond to a request.";
         break;
     case WebServiceWorkerResponseErrorResponseTypeOpaqueForClientRequest:
         errorMessage = errorMessage + "an \"opaque\" response was used for a client request.";
         break;
+    case WebServiceWorkerResponseErrorResponseTypeOpaqueRedirect:
+        errorMessage = errorMessage + "an \"opaqueredirect\" type response was used for a request which is not a navigation request.";
+        break;
     case WebServiceWorkerResponseErrorUnknown:
     default:
         errorMessage = errorMessage + "an unexpected error occurred.";
         break;
     }
     return errorMessage;
 }
 
+bool isNavigationRequest(WebURLRequest::FrameType frameType)
+{
+    return frameType != WebURLRequest::FrameTypeNone;
+}
+
 bool isClientRequest(WebURLRequest::FrameType frameType, WebURLRequest::RequestContext requestContext)
 {
-    return frameType != WebURLRequest::FrameTypeNone || requestContext == WebURLRequest::RequestContextSharedWorker || requestContext == WebURLRequest::RequestContextWorker;
+    return isNavigationRequest(frameType) || requestContext == WebURLRequest::RequestContextSharedWorker || requestContext == WebURLRequest::RequestContextWorker;
 }
 
 class NoopLoaderClient final : public GarbageCollectedFinalized<NoopLoaderClient>, public FetchDataLoader::Client {
     WTF_MAKE_NONCOPYABLE(NoopLoaderClient);
     USING_GARBAGE_COLLECTED_MIXIN(NoopLoaderClient);
 public:
     NoopLoaderClient() = default;
     void didFetchDataLoadedStream() override {}
     void didFetchDataLoadFailed() override {}
     DEFINE_INLINE_TRACE() { FetchDataLoader::Client::trace(visitor); }
@@ skipping 125 matching lines @@
         // The request mode of client requests should be "same-origin" but it is
         // not explicitly stated in the spec yet. So we need to check here.
         // FIXME: Set the request mode of client requests to "same-origin" and
         // remove this check when the spec will be updated.
         // Spec issue: https://github.com/whatwg/fetch/issues/101
         if (isClientRequest(m_frameType, m_requestContext)) {
             responseWasRejected(WebServiceWorkerResponseErrorResponseTypeOpaqueForClientRequest);
             return;
         }
     }
+    if (isNavigationRequest(m_frameType) && responseType == FetchResponseData::OpaqueRedirectType) {

[yhirano, 2015/08/07 14:22:02]

https://fetch.spec.whatwg.org/#http-fetch says

If one of the following conditions is true, return a network error:

response's type is "error".
request's mode is not "no-cors" and response's type is "opaque".
request is not a navigation request and response's type is "opaqueredirect".


Should this check be (!isNavigationRequest(m_frameType) && responseType ==
FetchResponseData::OpaqueRedirectType) ?

[horo, 2015/08/07 15:39:54]

Ah, yes.  Fixed.

+        responseWasRejected(WebServiceWorkerResponseErrorResponseTypeOpaqueRedirect);
+        return;
+    }
     if (response->bodyUsed()) {
         responseWasRejected(WebServiceWorkerResponseErrorBodyUsed);
         return;
     }
 
     response->setBodyPassed();
     WebServiceWorkerResponse webResponse;
     response->populateWebServiceWorkerResponse(webResponse);
     BodyStreamBuffer* buffer = response->internalBodyBuffer();
     if (buffer->hasBody()) {
@@ skipping 20 matching lines @@
     , m_state(Initial)
 {
 }
 
 DEFINE_TRACE(RespondWithObserver)
 {
     ContextLifecycleObserver::trace(visitor);
 }
 
 } // namespace blink