[1/3 blink] Support redirect option of Request and "opaqueredirect" response type.

Source/modules/fetch/FetchManager.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/fetch/FetchManager.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 19 matching lines @@
 #include "modules/fetch/ResponseInit.h"
 #include "platform/network/ResourceError.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/network/ResourceResponse.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/WebURLRequest.h"
 #include "wtf/HashSet.h"
 
 namespace blink {
 
+namespace {
+
+bool IsRedirectStatusCode(int statusCode)
+{
+    return (statusCode == 301 || statusCode == 302 || statusCode == 303 || statusCode == 307 || statusCode == 308);
+}
+
+} // namespace
+
 class FetchManager::Loader final : public NoBaseWillBeGarbageCollectedFinalized<FetchManager::Loader>, public ThreadableLoaderClient, public ContextLifecycleObserver {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(FetchManager::Loader);
 public:
     static PassOwnPtrWillBeRawPtr<Loader> create(ExecutionContext* executionContext, FetchManager* fetchManager, ScriptPromiseResolver* resolver, FetchRequestData* request)
     {
         return adoptPtrWillBeNoop(new Loader(executionContext, fetchManager, resolver, request));
     }
 
     ~Loader() override;
     DECLARE_VIRTUAL_TRACE();
@@ skipping 73 matching lines @@
         }
     }
     FetchResponseData* responseData = FetchResponseData::createWithBuffer(new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(handle)));
     responseData->setStatus(response.httpStatusCode());
     responseData->setStatusMessage(response.httpStatusText());
     for (auto& it : response.httpHeaderFields())
         responseData->headerList()->append(it.key, it.value);
     responseData->setURL(response.url());
     responseData->setMIMEType(response.mimeType());
 
     FetchResponseData* taintedResponse = responseData;

[falken, 2015/08/07 07:39:12]

Should this be initialized to nullptr? It looks like it necessarily is assigned
something in the if-else.

[horo, 2015/08/07 09:19:33]

Done.
I changed these code to fix the layout test failures
(http/tests/fetch/*/fetch-access-control-redirect*.html).

When the location header doesn't exist, we have to treat the response as a
normal response and execute tainting.

-    switch (m_request->tainting()) {
-    case FetchRequestData::BasicTainting:
-        taintedResponse = responseData->createBasicFilteredResponse();
-        break;
-    case FetchRequestData::CORSTainting:
-        taintedResponse = responseData->createCORSFilteredResponse();
-        break;
-    case FetchRequestData::OpaqueTainting:
-        taintedResponse = responseData->createOpaqueFilteredResponse();
-        break;
+
+    if (IsRedirectStatusCode(m_responseHttpStatusCode)) {

[yhirano, 2015/08/07 14:22:02]

ASSERT(redirect mode is "manual")?

[horo, 2015/08/07 15:39:53]

Done.

+        taintedResponse = responseData->createOpaqueRedirectFilteredResponse();
+    } else {
+        switch (m_request->tainting()) {
+        case FetchRequestData::BasicTainting:
+            taintedResponse = responseData->createBasicFilteredResponse();
+            break;
+        case FetchRequestData::CORSTainting:
+            taintedResponse = responseData->createCORSFilteredResponse();
+            break;
+        case FetchRequestData::OpaqueTainting:
+            taintedResponse = responseData->createOpaqueFilteredResponse();
+            break;
+        }
     }
     Response* r = Response::create(m_resolver->executionContext(), taintedResponse);
     r->headers()->setGuard(Headers::ImmutableGuard);
     m_resolver->resolve(r);
     m_resolver.clear();
 }
 
 void FetchManager::Loader::didFinishLoading(unsigned long, double)
 {
     ASSERT(!m_failed);
@@ skipping 174 matching lines @@
 
     if (m_request->method() != "GET" && m_request->method() != "HEAD") {
         if (BodyStreamBuffer* buffer = m_request->buffer()) {
             RefPtr<BlobDataHandle> blobDataHandle = buffer->drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::AllowBlobWithInvalidSize);
             RefPtr<FormData> httpBody(FormData::create());
             if (blobDataHandle)
                 httpBody->appendBlob(blobDataHandle->uuid(), blobDataHandle);
             request.setHTTPBody(httpBody);
         }
     }
-
+    request.setFetchRedirectMode(m_request->redirect());
     request.setUseStreamOnResponse(true);
 
     // "2. Append `Referer`/empty byte sequence, if |HTTPRequest|'s |referrer|
     // is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8
     // encoded, otherwise, to HTTPRequest's header list.
     // We set the referrer using workerGlobalScope's URL in
     // WorkerThreadableLoader.
 
     // "3. Append `Host`, ..."
     // FIXME: Implement this when the spec is fixed.
@@ skipping 108 matching lines @@
 
 DEFINE_TRACE(FetchManager)
 {
 #if ENABLE(OILPAN)
     visitor->trace(m_executionContext);
     visitor->trace(m_loaders);
 #endif
 }
 
 } // namespace blink