Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 126513003: Land Recent QUIC Changes. (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes. Add the override annotation to all necessary methods in .../quic/. Merge internal change: 59008686 https://codereview.chromium.org/126243002/ Enabled StopPacketProcessing unit test. Added EXPECT_CALL for OnUnauthenticatedPublicHeader. R=rch@chromium.org BUG=331630 https://codereview.chromium.org/113073003/ Add an end-to-end test which verifies that QUIC 13 does not generate QUIC_STREAM_RST_BEFORE_HEADERS_DECOMPRESSED errors. Merge internal change: 58990354 https://codereview.chromium.org/121883003/ Fix a bug in QuicSentPacketManager::ClearPreviousRetransmissions where the high water mark is not raised past the current transmission of a packet whose previous packet has been ACKed. This bug was first observer in jri's lab experiments. Fix QUIC bug related to ACKs of previous transmission of packets. Merge internal change: 58760014 https://codereview.chromium.org/125183004/ Correctly handle NACK-based "retransmission" of packets which no longer have retransmittable data associated with this. These can be the result of TLP retransmission or a current transmission of a packet whose previous transmission have been acked. Fix QUIC bug related to ACKs of previous transmission of packets. Merge internal change: 58758718 https://codereview.chromium.org/125183003/ Simplify RTO interaction between the QUIC sent packet manager and the send algorithm. The manager no longer needs to abandon each packet individually. Merge internal change: 58755766 https://codereview.chromium.org/125253004/ Remove a QUIC test only flag(limit_rto_increase_for_tests) to limit the RTO increase in EndToEndTests. This is no longer necessary now that two TLP's and early retransmit have been added. Merge internal change: 58591658 https://codereview.chromium.org/112953003/ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -142 lines) Patch
M net/quic/congestion_control/fix_rate_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/fix_rate_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_probe.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/inter_arrival_sender.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 1 chunk +10 lines, -1 line 0 comments Download
M net/quic/crypto/local_strike_register_client_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_connection_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 14 chunks +18 lines, -33 lines 0 comments Download
M net/quic/quic_default_packet_writer.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_framer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 12 chunks +50 lines, -37 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 7 chunks +123 lines, -37 lines 0 comments Download
M net/quic/quic_stream_sequencer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/delayed_verify_strike_register_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_clock.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 3 chunks +39 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-07 21:43:42 UTC) #1
Ryan Hamilton
LGTM since I have reviewed all the individual changes.
6 years, 11 months ago (2014-01-07 22:17:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/126513003/1
6 years, 11 months ago (2014-01-07 22:25:20 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242832
6 years, 11 months ago (2014-01-08 02:18:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/126513003/1
6 years, 11 months ago (2014-01-08 02:20:23 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 07:11:32 UTC) #6
Message was sent while issue was closed.
Change committed as 243507

Powered by Google App Engine
This is Rietveld 408576698