Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1265113002: X87: VectorICs: refactoring to eliminate "for queries only" vector ic mode. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: VectorICs: refactoring to eliminate "for queries only" vector ic mode. port 1a5751f9b3ca682fadb6fce8202dda2db5b017c6 (r29956) original commit message: Since we need the notion of a dummy vector ic, we can use that to avoid a special case of the IC constructor. Also, consolidate the two dummy ICs into one. BUG= Committed: https://crrev.com/200d49bf4a969b085b754eacdc2768dd7142966c Cr-Commit-Position: refs/heads/master@{#29963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/ic/x87/ic-x87.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-03 02:20:12 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-03 02:44:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265113002/1
5 years, 4 months ago (2015-08-03 02:44:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-03 03:09:07 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 03:09:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/200d49bf4a969b085b754eacdc2768dd7142966c
Cr-Commit-Position: refs/heads/master@{#29963}

Powered by Google App Engine
This is Rietveld 408576698