Source/platform/heap/ThreadState.cpp - Issue 1265103003: Invalidate cross-thread persistents on heap termination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 1265103003: Invalidate cross-thread persistents on heap termination. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: clarify comments + style tweaks Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index 079ac1912d0ce202fbbc8a761bbc15343b422211..cca3c4608db55b2c666642eb5baabd9c7c89f011 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -243,6 +243,8 @@ void ThreadState::cleanup()

// thread local GC.

prepareHeapForTermination();

haraken 2015/08/03 00:45:25 Nit: I'd rename this to prepareForThreadStateTermi

sof 2015/08/03 08:30:04 Done.

+ ThreadState::crossThreadPersistentRegion().prepareForThreadStateTermination(this);

// Do thread local GC's as long as the count of thread local Persistents

// changes and is above zero.

int oldCount = -1;