src/IceCfgNode.cpp - Issue 1265093002: Subzero: Expand the liveness consistency check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCfgNode.cpp

Issue 1265093002: Subzero: Expand the liveness consistency check. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCfgNode.cpp

diff --git a/src/IceCfgNode.cpp b/src/IceCfgNode.cpp

index cae5d3770e796b9d64a7919efa2b31cc92051682..f319041c6646103fa9d24367b44e214123b9707c 100644

--- a/src/IceCfgNode.cpp

+++ b/src/IceCfgNode.cpp

@@ -614,10 +614,7 @@ bool CfgNode::liveness(Liveness *Liveness) {

// validation is not.)

LivenessBV LiveOrig = Live;

Live.resize(Liveness->getNumGlobalVars());

- // Non-global arguments in the entry node are allowed to be live on

- // entry.

- bool IsEntry = (Func->getEntryNode() == this);

- if (!(IsEntry || Live == LiveOrig)) {

+ if (Live != LiveOrig) {

if (BuildDefs::dump()) {

// This is a fatal liveness consistency error. Print some

// diagnostics and abort.

« no previous file with comments | « no previous file | src/IceTargetLoweringARM32.cpp » ('j') | no next file with comments »