Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2615)

Unified Diff: cc/scheduler/scheduler.cc

Issue 1265023005: cc: Add SchedulerStateMachine::DidDraw and use for forced draws (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@WillDidAction0
Patch Set: Remove SetDrawResult and pass result as argument instead Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/scheduler/scheduler_state_machine.h » ('j') | cc/scheduler/scheduler_state_machine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.cc
diff --git a/cc/scheduler/scheduler.cc b/cc/scheduler/scheduler.cc
index 072086fe0dd262ea9bc03e66ccc4d2cb91c08d5b..295a2912b53323e3f1b1278fc2d66a56e765cf8c 100644
--- a/cc/scheduler/scheduler.cc
+++ b/cc/scheduler/scheduler.cc
@@ -606,16 +606,21 @@ void Scheduler::OnBeginImplFrameDeadline() {
}
void Scheduler::DrawAndSwapIfPossible() {
+ state_machine_.WillDraw();
compositor_timing_history_->WillDraw();
DrawResult result = client_->ScheduledActionDrawAndSwapIfPossible();
- state_machine_.DidDrawIfPossibleCompleted(result);
compositor_timing_history_->DidDraw();
+ bool did_request_swap = true;
+ state_machine_.DidDraw(did_request_swap, result);
}
void Scheduler::DrawAndSwapForced() {
+ state_machine_.WillDraw();
compositor_timing_history_->WillDraw();
- client_->ScheduledActionDrawAndSwapForced();
+ DrawResult result = client_->ScheduledActionDrawAndSwapForced();
compositor_timing_history_->DidDraw();
+ bool did_request_swap = true;
+ state_machine_.DidDraw(did_request_swap, result);
}
void Scheduler::SetDeferCommits(bool defer_commits) {
@@ -680,22 +685,18 @@ void Scheduler::ProcessScheduledActions() {
tracked_objects::ScopedTracker tracking_profile6(
FROM_HERE_WITH_EXPLICIT_FUNCTION(
"461509 Scheduler::ProcessScheduledActions6"));
- bool did_request_swap = true;
- state_machine_.WillDraw(did_request_swap);
DrawAndSwapIfPossible();
break;
}
- case SchedulerStateMachine::ACTION_DRAW_AND_SWAP_FORCED: {
- bool did_request_swap = true;
- state_machine_.WillDraw(did_request_swap);
+ case SchedulerStateMachine::ACTION_DRAW_AND_SWAP_FORCED:
DrawAndSwapForced();
break;
- }
case SchedulerStateMachine::ACTION_DRAW_AND_SWAP_ABORT: {
// No action is actually performed, but this allows the state machine to
// advance out of its waiting to draw state without actually drawing.
bool did_request_swap = false;
- state_machine_.WillDraw(did_request_swap);
+ state_machine_.WillDraw();
+ state_machine_.DidDraw(did_request_swap, DRAW_SUCCESS);
break;
}
case SchedulerStateMachine::ACTION_BEGIN_OUTPUT_SURFACE_CREATION:
« no previous file with comments | « no previous file | cc/scheduler/scheduler_state_machine.h » ('j') | cc/scheduler/scheduler_state_machine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698