Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1265023004: Revert of Bringing 4 more BluetoothTest.* unit tests to Mac (Closed)

Created:
5 years, 4 months ago by dmurph
Modified:
5 years, 4 months ago
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@scheibtest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Bringing 4 more BluetoothTest.* unit tests to Mac (patchset #6 id:160001 of https://codereview.chromium.org/1246913006/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=516032 Linking failure on mac debug bot. Original issue's description: > Modified BluetoothTestMac to support device discovery tests. > > Also implemented utility function FindCBUUIDForHashTarget() to find > relatively simple CBUUIDs mapping (under SHA256 plus truncating) to > a 6 byte address with the first 3 bytes specified. Used to choose > CBUUID / bluetooth address pairs for testing. > > BUG=511008 > > Committed: https://crrev.com/5a0eceb28201302bcb45621015119bd73351d659 > Cr-Commit-Position: refs/heads/master@{#341400} TBR=armansito@chromium.org,davidben@chromium.org,scheib@chromium.org,krstnmnlsn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=511008 Committed: https://crrev.com/cec0b556a5d67a411e7beffd01a7e793ff8f202b Cr-Commit-Position: refs/heads/master@{#341410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -283 lines) Patch
M device/bluetooth/bluetooth_adapter_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 7 chunks +22 lines, -45 lines 0 comments Download
M device/bluetooth/bluetooth_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.h View 3 chunks +2 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_low_energy_device_mac.mm View 2 chunks +13 lines, -21 lines 0 comments Download
M device/bluetooth/test/android/java/src/org/chromium/device/bluetooth/Fakes.java View 3 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.h View 2 chunks +5 lines, -23 lines 0 comments Download
M device/bluetooth/test/bluetooth_test.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/test/bluetooth_test_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.h View 2 chunks +0 lines, -8 lines 0 comments Download
M device/bluetooth/test/bluetooth_test_mac.mm View 2 chunks +0 lines, -159 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmurph
Created Revert of Bringing 4 more BluetoothTest.* unit tests to Mac
5 years, 4 months ago (2015-07-31 21:05:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1265023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1265023004/1
5 years, 4 months ago (2015-07-31 21:06:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 21:08:29 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 21:09:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cec0b556a5d67a411e7beffd01a7e793ff8f202b
Cr-Commit-Position: refs/heads/master@{#341410}

Powered by Google App Engine
This is Rietveld 408576698