Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: src/IceAssemblerX86Base.h

Issue 1265023003: Clarify which type "Label" refers to (generic vs X86) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: not LabelBase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 //===- subzero/src/IceAssemblerX86Base.h - base x86 assembler -*- C++ -*---===// 1 //===- subzero/src/IceAssemblerX86Base.h - base x86 assembler -*- C++ -*---===//
2 // 2 //
3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
4 // for details. All rights reserved. Use of this source code is governed by a 4 // for details. All rights reserved. Use of this source code is governed by a
5 // BSD-style license that can be found in the LICENSE file. 5 // BSD-style license that can be found in the LICENSE file.
6 // 6 //
7 // Modified by the Subzero authors. 7 // Modified by the Subzero authors.
8 // 8 //
9 //===----------------------------------------------------------------------===// 9 //===----------------------------------------------------------------------===//
10 // 10 //
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 143
144 void padWithNop(intptr_t Padding) override { 144 void padWithNop(intptr_t Padding) override {
145 while (Padding > MAX_NOP_SIZE) { 145 while (Padding > MAX_NOP_SIZE) {
146 nop(MAX_NOP_SIZE); 146 nop(MAX_NOP_SIZE);
147 Padding -= MAX_NOP_SIZE; 147 Padding -= MAX_NOP_SIZE;
148 } 148 }
149 if (Padding) 149 if (Padding)
150 nop(Padding); 150 nop(Padding);
151 } 151 }
152 152
153 Label *getOrCreateCfgNodeLabel(SizeT NodeNumber) override; 153 Ice::Label *getCfgNodeLabel(SizeT NodeNumber) override;
154 void bindCfgNodeLabel(SizeT NodeNumber) override; 154 void bindCfgNodeLabel(SizeT NodeNumber) override;
155 Label *getOrCreateCfgNodeLabel(SizeT Number);
155 Label *getOrCreateLocalLabel(SizeT Number); 156 Label *getOrCreateLocalLabel(SizeT Number);
156 void bindLocalLabel(SizeT Number); 157 void bindLocalLabel(SizeT Number);
157 158
158 bool fixupIsPCRel(FixupKind Kind) const override { 159 bool fixupIsPCRel(FixupKind Kind) const override {
159 // Currently assuming this is the only PC-rel relocation type used. 160 // Currently assuming this is the only PC-rel relocation type used.
160 // TODO(jpp): Traits.PcRelTypes.count(Kind) != 0 161 // TODO(jpp): Traits.PcRelTypes.count(Kind) != 0
161 return Kind == Traits::PcRelFixup; 162 return Kind == Traits::PcRelFixup;
162 } 163 }
163 164
164 // Operations to emit GPR instructions (and dispatch on operand type). 165 // Operations to emit GPR instructions (and dispatch on operand type).
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 emitUint8(0x66); 1039 emitUint8(0x66);
1039 } 1040 }
1040 1041
1041 } // end of namespace X86Internal 1042 } // end of namespace X86Internal
1042 1043
1043 } // end of namespace Ice 1044 } // end of namespace Ice
1044 1045
1045 #include "IceAssemblerX86BaseImpl.h" 1046 #include "IceAssemblerX86BaseImpl.h"
1046 1047
1047 #endif // SUBZERO_SRC_ICEASSEMBLERX86BASE_H 1048 #endif // SUBZERO_SRC_ICEASSEMBLERX86BASE_H
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698