Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: src/IceAssemblerX8632.h

Issue 1265023003: Clarify which type "Label" refers to (generic vs X86) (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: not LabelBase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/IceAssemblerMIPS32.h ('k') | src/IceAssemblerX86Base.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 //===- subzero/src/IceAssemblerX8632.h - Assembler for x86-32 ---*- C++ -*-===// 1 //===- subzero/src/IceAssemblerX8632.h - Assembler for x86-32 ---*- C++ -*-===//
2 // 2 //
3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 3 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
4 // for details. All rights reserved. Use of this source code is governed by a 4 // for details. All rights reserved. Use of this source code is governed by a
5 // BSD-style license that can be found in the LICENSE file. 5 // BSD-style license that can be found in the LICENSE file.
6 // 6 //
7 // Modified by the Subzero authors. 7 // Modified by the Subzero authors.
8 // 8 //
9 //===----------------------------------------------------------------------===// 9 //===----------------------------------------------------------------------===//
10 // 10 //
(...skipping 20 matching lines...) Expand all
31 #include "IceTypes.h" 31 #include "IceTypes.h"
32 #include "IceUtils.h" 32 #include "IceUtils.h"
33 33
34 namespace Ice { 34 namespace Ice {
35 35
36 class TargetX8632; 36 class TargetX8632;
37 37
38 namespace X8632 { 38 namespace X8632 {
39 39
40 using Immediate = ::Ice::X86Internal::Immediate; 40 using Immediate = ::Ice::X86Internal::Immediate;
41 using Label = ::Ice::X86Internal::Label;
jvoung (off chromium) 2015/08/03 17:19:21 I think this was actually the only line needed to
41 42
42 class AssemblerX8632 : public X86Internal::AssemblerX86Base<TargetX8632> { 43 class AssemblerX8632 : public X86Internal::AssemblerX86Base<TargetX8632> {
43 AssemblerX8632(const AssemblerX8632 &) = delete; 44 AssemblerX8632(const AssemblerX8632 &) = delete;
44 AssemblerX8632 &operator=(const AssemblerX8632 &) = delete; 45 AssemblerX8632 &operator=(const AssemblerX8632 &) = delete;
45 46
46 public: 47 public:
47 explicit AssemblerX8632(bool use_far_branches = false) 48 explicit AssemblerX8632(bool use_far_branches = false)
48 : X86Internal::AssemblerX86Base<TargetX8632>(Asm_X8632, 49 : X86Internal::AssemblerX86Base<TargetX8632>(Asm_X8632,
49 use_far_branches) {} 50 use_far_branches) {}
50 ~AssemblerX8632() override = default; 51 ~AssemblerX8632() override = default;
51 52
52 static bool classof(const Assembler *Asm) { 53 static bool classof(const Assembler *Asm) {
53 return Asm->getKind() == Asm_X8632; 54 return Asm->getKind() == Asm_X8632;
54 } 55 }
55 }; 56 };
56 57
57 } // end of namespace X8632 58 } // end of namespace X8632
58 } // end of namespace Ice 59 } // end of namespace Ice
59 60
60 #endif // SUBZERO_SRC_ICEASSEMBLERX8632_H 61 #endif // SUBZERO_SRC_ICEASSEMBLERX8632_H
OLDNEW
« no previous file with comments | « src/IceAssemblerMIPS32.h ('k') | src/IceAssemblerX86Base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698