Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1264973002: Disable 'Ok Google' hotwording on desktop Chrome. (Closed)

Created:
5 years, 4 months ago by Matt Giuca
Modified:
5 years, 4 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable 'Ok Google' hotwording on desktop Chrome. This feature has been removed completely from Windows, Mac and Linux builds of Chrome. ChromeOS is unaffected. This removes the checkbox from chrome://settings and the prompt to activate it from the google.com search page. BUG=506098, 507384 TEST=On ChromeOS (official builds), go to chrome://settings. Should see "Enable Ok Google" checkbox. TEST=On Windows Chrome (official builds), go to chrome://settings. Should NOT see "Enable Ok Google" checkbox. Committed: https://crrev.com/3cd6a820c499c11f666b2f72fdf28a65ee87da83 Cr-Commit-Position: refs/heads/master@{#342245}

Patch Set 1 #

Patch Set 2 : Fix syntax errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M build/common.gypi View 1 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264973002/20001
5 years, 4 months ago (2015-07-31 09:25:54 UTC) #2
Matt Giuca
Hi Nico, see bug for context.
5 years, 4 months ago (2015-07-31 09:26:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-31 10:30:14 UTC) #6
Nico
On 2015/07/31 10:30:14, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-07-31 14:05:57 UTC) #7
Matt Giuca
On 2015/07/31 14:05:57, Nico (hiding) wrote: > Both bugs sound like no decision about this ...
5 years, 4 months ago (2015-08-03 06:18:30 UTC) #8
Matt Giuca
+brettw (maybe Nico is away, judging by his name).
5 years, 4 months ago (2015-08-06 03:07:58 UTC) #10
Nico
lgtm. sorry for the delay!
5 years, 4 months ago (2015-08-06 04:09:57 UTC) #11
Matt Giuca
On 2015/08/06 04:09:57, Nico (hiding) wrote: > lgtm. sorry for the delay! Oh thanks, sorry ...
5 years, 4 months ago (2015-08-06 04:19:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264973002/20001
5 years, 4 months ago (2015-08-06 04:20:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89500)
5 years, 4 months ago (2015-08-06 06:08:47 UTC) #16
brettw
lgtm
5 years, 4 months ago (2015-08-06 19:25:56 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264973002/20001
5 years, 4 months ago (2015-08-07 00:09:33 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-07 00:46:22 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 00:46:57 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cd6a820c499c11f666b2f72fdf28a65ee87da83
Cr-Commit-Position: refs/heads/master@{#342245}

Powered by Google App Engine
This is Rietveld 408576698