Disable tap suppression controller on Android WebView

Disable tap suppression controller on Android WebView

WebView apps may override WebView#computeScroll to customize
fling/scroll. So the animations may not be ticked (if the overriden
computeScroll does not call super). InputHandlerProxy could see a
fling starting but never animating. Tap suppression controller
will be confused in this case and suppress too aggressively.

Just disable it on Android WebView.

BUG=514783

[hush (inactive), 2015-07-31 01:29:08]

hush@chromium.org changed reviewers:
+ jdduke@chromium.org

[hush (inactive), 2015-07-31 01:29:08]

PTAL!

[hush (inactive), 2015-07-31 01:37:24]

Patchset #1 (id:1) has been deleted

[hush (inactive), 2015-07-31 01:37:30]

Patchset #1 (id:20001) has been deleted

[jdduke (slow), 2015-07-31 16:35:25]

Hmm, yeah I guess this isn't setup well for this kind of change.

So, what I'm thinking is that we shift the enabled value to
ui::GestureConfiguration. For historical reasons this is just a singleton, but
on WebView startup (I imagine there's some kind of global webview startup phase
that runs some native code before the web contents is created) we can just set
the "enabled" bit to false? I'll upload a change that would allow that, then all
you'll have to do is hook in to:

ui::GestureConfiguration->GetInstance()->set_fling_touchscreen_tap_suppression_enabled(false);

https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_impl.cc:36: #include
"content/browser/renderer_host/compositor_impl_android.h"
We definitely can't include this without a guard.

[hush (inactive), 2015-07-31 17:49:01]

On 2015/07/31 16:35:25, jdduke wrote:
> Hmm, yeah I guess this isn't setup well for this kind of change.
> 
> So, what I'm thinking is that we shift the enabled value to
> ui::GestureConfiguration. For historical reasons this is just a singleton, but
> on WebView startup (I imagine there's some kind of global webview startup
phase
> that runs some native code before the web contents is created) we can just set
> the "enabled" bit to false? I'll upload a change that would allow that, then
all
> you'll have to do is hook in to:
> 
>
ui::GestureConfiguration->GetInstance()->set_fling_touchscreen_tap_suppression_enabled(false);
> 
>
https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
> File content/browser/renderer_host/render_widget_host_impl.cc (right):
> 
>
https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
> content/browser/renderer_host/render_widget_host_impl.cc:36: #include
> "content/browser/renderer_host/compositor_impl_android.h"
> We definitely can't include this without a guard.

Let's try to do this in one simple change. This needs to cherry picked back to
m45.

I will investigate how to call ui::GestureConfiguration during webview startup.

[jdduke (slow), 2015-07-31 18:09:55]

On 2015/07/31 17:49:01, hush wrote:
> On 2015/07/31 16:35:25, jdduke wrote:
> > Hmm, yeah I guess this isn't setup well for this kind of change.
> > 
> > So, what I'm thinking is that we shift the enabled value to
> > ui::GestureConfiguration. For historical reasons this is just a singleton,
but
> > on WebView startup (I imagine there's some kind of global webview startup
> phase
> > that runs some native code before the web contents is created) we can just
set
> > the "enabled" bit to false? I'll upload a change that would allow that, then
> all
> > you'll have to do is hook in to:
> > 
> >
>
ui::GestureConfiguration->GetInstance()->set_fling_touchscreen_tap_suppression_enabled(false);
> > 
> >
>
https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
> > File content/browser/renderer_host/render_widget_host_impl.cc (right):
> > 
> >
>
https://codereview.chromium.org/1264963003/diff/40001/content/browser/rendere...
> > content/browser/renderer_host/render_widget_host_impl.cc:36: #include
> > "content/browser/renderer_host/compositor_impl_android.h"
> > We definitely can't include this without a guard.
> 
> Let's try to do this in one simple change. This needs to cherry picked back to
> m45.

Sure, but I don't think we want to start leaking semantics based on
|using_browser_compositor| outside of Android-specific code.
https://codereview.chromium.org/1267693004/ is a fairly simple change.

[jdduke (slow), 2015-07-31 18:12:12]

One hack I considered was returning NO_CONSUMER_EXISTS for a fling cancel if it
cancels a fling that was never animated (from input_handler_proxy.cc). But
that's pretty dirty (simple though =/)...

[hush (inactive), 2015-07-31 23:50:09]

abandoning