Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1264913005: Fix a -Wcovered-switch-default warning in emitJumpTables. (Closed)

Created:
5 years, 4 months ago by jvoung (off chromium)
Modified:
5 years, 4 months ago
Reviewers:
Jim Stichnoth, ascull, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a -Wcovered-switch-default warning in emitJumpTables. The Subzero build inside of the LLVM build system turns this on. BUG=none R=ascull@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c2648c2db7f2d0c10ef54393098fe74f65296c45

Patch Set 1 #

Patch Set 2 : add warning to default.wq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Makefile.standalone View 1 1 chunk +4 lines, -1 line 0 comments Download
M src/IceCfg.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 4 months ago (2015-07-30 22:30:26 UTC) #2
ascull
On 2015/07/30 22:30:26, jvoung wrote: lgtm
5 years, 4 months ago (2015-07-30 22:32:11 UTC) #3
jvoung (off chromium)
5 years, 4 months ago (2015-07-31 04:29:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c2648c2db7f2d0c10ef54393098fe74f65296c45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698