[Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher

Source/core/workers/WorkerThread.cpp

Index: Source/core/workers/WorkerThread.cpp
diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp
index 5c0b410876bd36448b622d837a969523647b7de1..afcc013a55dbb06b92ea2421d3ed74e5b9caeaa6 100644
--- a/Source/core/workers/WorkerThread.cpp
+++ b/Source/core/workers/WorkerThread.cpp
@@ -250,6 +250,10 @@ void WorkerThread::initialize(PassOwnPtr<WorkerThreadStartupData> startupData)
         script->initializeContextIfNeeded();
     m_workerGlobalScope->workerInspectorController()->workerContextInitialized(startMode == PauseWorkerGlobalScopeOnStart);
 
+    if (script->scriptState()->contextIsValid()) {
+        m_workerReportingProxy.didInitializeWorkerContext();
+    }

[falken, 2015/08/10 04:10:56]

This particular change lgtm.

The existing code is pretty weird as dcheng@ says: it's not clear why we
continue with everything even when isExecutionForbidden() is false and call
workerInspectorController()->workerContextInitialized() when the context may not
have been initialized.

For some clues, I see the initializeContextIfNeeded call was added in
https://codereview.chromium.org/270873005/ to fix a bug with DevTools.

blink-worker team should do some clean up/commenting here but it's not required
for this review.

+
     OwnPtrWillBeRawPtr<CachedMetadataHandler> handler(workerGlobalScope()->createWorkerScriptCachedMetadataHandler(scriptURL, cachedMetaData.get()));
     bool success = script->evaluate(ScriptSourceCode(sourceCode, scriptURL), nullptr, handler.get(), v8CacheOptions);
     m_workerGlobalScope->didEvaluateWorkerScript();